Skip to content

Feat: add tag policy SL #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

typeid
Copy link
Member

@typeid typeid commented Mar 17, 2025

This PR adds a new SL to send for customers that add tag policies which block instance creations: (https://docs.aws.amazon.com/organizations/latest/userguide/orgs_manage_policies_tag-policies.html)

MAPI error:


 - lastTransitionTime: "2025-03-17T10:44:59Z"
      message: 'error launching instance: The resource is missing the tag key(s) ''ExampleTag''
        specified by the tag policy.'
      reason: MachineCreationFailed
      status: "False"
      type: MachineCreation

@openshift-ci openshift-ci bot requested review from MitaliBhalla and weherdh March 17, 2025 10:58
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: typeid
Once this PR has been reviewed and has the lgtm label, please assign brizrobbo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

@typeid: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant