feat: Garbage collector input #1623
Conversation
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Mateus Oliveira <[email protected]>
Signed-off-by: Mateus Oliveira <[email protected]>
mateusoliveira43
force-pushed
the
feat/nac-garbage-collector
branch
from
b010f27 to
599210d
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
| @@ -447,6 +447,11 @@ type NonAdmin struct { | |||
| // which restore spec field values to enforce | |||
| // +optional | |||
| EnforceRestoreSpec *velero.RestoreSpec `json:"enforceRestoreSpec,omitempty"` | |||
|
|
|||
There was a problem hiding this comment.
s/non admin objects/non admin related objects
We are cleaning up residual Velero Objects and secrets, right ? (Not the actual Non-Admin prefixed objects)
There was a problem hiding this comment.
yes, objects NAC controller created in OADP namespace and for some reason they were not properly deleted, GC will do this job
will make the change
There was a problem hiding this comment.
Please revise PR title/description of the same detail.
There was a problem hiding this comment.
do not see other places that needs changing. Can you point it to me?
There was a problem hiding this comment.
feat: Garbage collector input
do not convey that this GC is limited to NAC created resources in oadp-operator namespace.
Signed-off-by: Mateus Oliveira <[email protected]>
|
@mateusoliveira43: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Why the changes were made
Allow admin users to configure NAC garbage collection frequency migtools/oadp-non-admin#145
How to test the changes made
Follow instructions from NAC PR migtools/oadp-non-admin#152