reenable nightly rhcos build #30134
reenable nightly rhcos build #30134
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
cheesesashimi
force-pushed
the
zzlotnik/reenable-nightly-rhcos-builds
branch
6 times, most recently
from
8645cf9 to
ca5f1b3
Compare
|
/assign cgwalters |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| FROM build-image:latest | ||
| ARG RHELVER="<invalid>" | ||
| ENV RHELVER=$RHELVER | ||
| ENV COSA_NO_KVM=1 |
There was a problem hiding this comment.
I was trying to make the Dockerfile reusable for once we have additional RHELVER. I wanted it to fail fast if the wrong RHELVER was used, but I can make it default to something else.
|
Worth trying anyways, let's do any fixes as followups |
openshift-ci
bot
added
lgtm
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@cheesesashimi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| value: rhel-8.6 | ||
| dockerfile_literal: | | ||
| # This performs the RHCOS build itself. | ||
| # TODO: Move this Dockerfile into the openshift/os repository so we can |
There was a problem hiding this comment.
Note that Dockerfiles need to stay here to avoid the issue where Prow uses only the current one from the branch during the test
There was a problem hiding this comment.
I know Prow does some image build caching if you use build_root to point to a Dockerfile in your repo. I didn't realize it also did that if you used a dockerfile_path like this.
There was a problem hiding this comment.
https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image hum, it's not clear indeed how safe it is to have non-buildroot images inside the repo
| # TODO: Move this Dockerfile into the openshift/os repository so we can | ||
| # easily reuse it for all RHCOS / SCOS versions via setting the build arg. | ||
| FROM build-image:latest | ||
| ARG RHELVER="<invalid>" |
There was a problem hiding this comment.
We probably only want to test the default one here so we don't need this logic. COSA will be able to figure out the default by itself in the future.
There was a problem hiding this comment.
That's fine with me. I'll update the RHELVER build arg default to rhel-8.6.
cheesesashimi
force-pushed
the
zzlotnik/reenable-nightly-rhcos-builds
branch
from
ca5f1b3 to
18e5ce3
Compare
cheesesashimi
force-pushed
the
zzlotnik/reenable-nightly-rhcos-builds
branch
from
18e5ce3 to
8287e76
Compare
|
/lgtm |
|
Let's wait until CI is green and then unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, cheesesashimi, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fine with me. FYI: Disregard any failure messages related to |
|
Hum, I'm updating the CoreOS layering PR and I found things to change in this one so I'll push an alternative. |
Do you mean that you'll fork this PR, add your changes and open a new PR (or append to #30019)? Or would you like me to add some of your changes into this one? |
|
Related to openshift/os#882 |
|
I've made #30276. Not sure I can push here. |
|
This PR has been superceded by #30276. Closing. |
This re-enables the nightly RHCOS builds to push to
registry.ci.openshift.org/rhcos-devel/rhel-coreos:latest.