Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oadp-operator: modify periodic run yo use ocp-4.19 #61355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oadp-operator: modify periodic run yo use ocp-4.19 #61355

wants to merge 1 commit into from
+75 −1,372

Conversation

tareqalayan
Copy link
Contributor

No description provided.

mateusoliveira43
mateusoliveira43 reviewed Feb 6, 2025
View reviewed changes
ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-master__4.19.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we run OADP CI jobs on 4.14,15,16,17 and 18 for master branch. Should we remove all and just run them on 4.19?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateusoliveira43 yes the current oadp should run with 4.19 @weshayutin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. For master branch however I would keep 4.18 just because it's a stable ocp release and it would be easier to find flakes outside of oadp.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 10, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 10, 2025
@tareqalayan tareqalayan force-pushed the oadp-ocp-19 branch 3 times, most recently from d3a2e8f to 24a6766 Compare February 11, 2025 11:33
@weshayutin
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@weshayutin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

mateusoliveira43

This comment was marked as resolved.

Sign in to view

@tareqalayan
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@tareqalayan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tareqalayan
Once this PR has been reviewed and has the lgtm label, please ask for approval from mateusoliveira43. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpryc mpryc mentioned this pull request Feb 11, 2025
Closed
@weshayutin
Copy link
Contributor

@mpryc @tareqalayan @mateusoliveira43
I'm fine w/ replacing 4.18 w/ 4.19 as long as we have at least one older version e.g. 4.17 running as well.
Ultimately when 4.19 becomes stable, master can be 4.19 only but that time is not yet.
not yet..

@mpryc
Copy link
Contributor

mpryc commented Feb 11, 2025

@mpryc @tareqalayan @mateusoliveira43 I'm fine w/ replacing 4.18 w/ 4.19 as long as we have at least one older version e.g. 4.17 running as well. Ultimately when 4.19 becomes stable, master can be 4.19 only but that time is not yet. not yet..

100% agree

@tareqalayan
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@tareqalayan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@tareqalayan: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-oadp-operator-master-4.19-ci-index openshift/oadp-operator presubmit Presubmit changed
pull-ci-openshift-oadp-operator-master-4.19-e2e-test-aws openshift/oadp-operator presubmit Presubmit changed
pull-ci-openshift-oadp-operator-master-4.19-e2e-test-kubevirt-aws openshift/oadp-operator presubmit Presubmit changed
pull-ci-openshift-oadp-operator-master-4.19-images openshift/oadp-operator presubmit Presubmit changed
periodic-ci-openshift-oadp-operator-master-4.19-e2e-test-kubevirt-aws-periodic N/A periodic Periodic changed
periodic-ci-openshift-oadp-operator-master-4.19-e2e-test-aws-periodic N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpryc mpryc mpryc left review comments

@mateusoliveira43 mateusoliveira43 mateusoliveira43 requested changes

@sseago sseago Awaiting requested review from sseago

Assignees

@mateusoliveira43 mateusoliveira43

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tareqalayan @weshayutin @openshift-ci-robot @mpryc @mateusoliveira43 @openshift-merge-robot