This repository has been archived by the owner on Jul 23, 2020. It is now read-only.
Refactor DeploymentsService to use DeploymentApiService #2925
Milestone
Comments
This was referenced Apr 9, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 10, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 10, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 10, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 10, 2018
Remove unused HTTP-related imports and properties as DeploymentsService now delegates all of this work to DeploymentApiService related to openshiftio/openshift.io#2925
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 10, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 10, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 10, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 10, 2018
Remove unused HTTP-related imports and properties as DeploymentsService now delegates all of this work to DeploymentApiService related to openshiftio/openshift.io#2925
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 11, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 11, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 11, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 11, 2018
Remove unused HTTP-related imports and properties as DeploymentsService now delegates all of this work to DeploymentApiService related to openshiftio/openshift.io#2925
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 11, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 11, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 11, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 11, 2018
Remove unused HTTP-related imports and properties as DeploymentsService now delegates all of this work to DeploymentApiService related to openshiftio/openshift.io#2925
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 12, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 12, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 12, 2018
andrewazores
added a commit
to andrewazores/fabric8-ui
that referenced
this issue
Apr 12, 2018
Remove unused HTTP-related imports and properties as DeploymentsService now delegates all of this work to DeploymentApiService related to openshiftio/openshift.io#2925
sanketpathak
pushed a commit
to sanketpathak/fabric8-ui
that referenced
this issue
May 6, 2018
…vice (fabric8-ui#2719) * fix(deployments): refactor DeploymentsService to consume DeploymentApiService related to openshiftio/openshift.io#2925 * fix(deployments): add deleteDeployment and scalePods to DeploymentApiService fixes openshiftio/openshift.io#2925 * test(deployments): assert HTTP request method types related to openshiftio/openshift.io#2925 * fix(deployments): remove unused imports and properties Remove unused HTTP-related imports and properties as DeploymentsService now delegates all of this work to DeploymentApiService related to openshiftio/openshift.io#2925
sanketpathak
pushed a commit
to sanketpathak/fabric8-ui
that referenced
this issue
May 6, 2018
…vice (fabric8-ui#2719) * fix(deployments): refactor DeploymentsService to consume DeploymentApiService related to openshiftio/openshift.io#2925 * fix(deployments): add deleteDeployment and scalePods to DeploymentApiService fixes openshiftio/openshift.io#2925 * test(deployments): assert HTTP request method types related to openshiftio/openshift.io#2925 * fix(deployments): remove unused imports and properties Remove unused HTTP-related imports and properties as DeploymentsService now delegates all of this work to DeploymentApiService related to openshiftio/openshift.io#2925
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Parent: #2921
Task
Once the generalized DeploymentApiService is available, the DeploymentsService should be refactored as a layer on top of the DeploymentApiService. Any non-Deployments consumers of the DeploymentsService should also be refactored to either consume the DeploymentApiService directly, or to also roll their own service layered on top of the DeploymentApiService to implement any additional functionality desired (ex. caching, polling, data format transformation).
The text was updated successfully, but these errors were encountered: