Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formats/zeiss: document zstd compression #87

Merged
merged 1 commit into from
May 21, 2024

Conversation

bgilbert
Copy link
Member

No description provided.

@bgilbert
Copy link
Member Author

@iewchen, could you give this a quick check?

@openslide-bot
Copy link

openslide-bot commented May 21, 2024

DCO signed off ✔️

All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1.

@iewchen
Copy link
Contributor

iewchen commented May 21, 2024

Thanks! Looks good.

That zstd1 header can have size other than 3 bytes, however in practice it is always 3 regardless whether HiLo is used. I'd say this version is correct according to our best knowledge. We can improve it if Zeiss releases more ZSTD details.

@bgilbert
Copy link
Member Author

Ah yeah, good point. I've updated the wording to equivocate a bit more on the header length.

@bgilbert bgilbert merged commit 842f830 into openslide:main May 21, 2024
2 checks passed
@bgilbert bgilbert deleted the czi-zstd branch May 21, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants