[COMMON] rewrite Configuration by java 17 record (#1758)

app/src/main/java/org/astraea/app/performance/DataGenerator.java

@@ -41,9 +41,9 @@ static DataGenerator of(
       Performance.Argument argument) {
     if (queues.size() == 0) return terminatedGenerator();
 
-    var keyDistConfig = Configuration.of(argument.keyDistributionConfig);
-    var keySizeDistConfig = Configuration.of(argument.keySizeDistributionConfig);
-    var valueDistConfig = Configuration.of(argument.valueDistributionConfig);
+    var keyDistConfig = new Configuration(argument.keyDistributionConfig);
+    var keySizeDistConfig = new Configuration(argument.keySizeDistributionConfig);
+    var valueDistConfig = new Configuration(argument.valueDistributionConfig);
     var dataSupplier =
         RecordGenerator.builder()
             .batchSize(argument.transactionSize)

app/src/main/java/org/astraea/app/web/BalancerHandler.java

@@ -113,7 +113,7 @@ public CompletionStage<Response> put(Channel channel) {
     final var request = channel.request(TypeRef.of(BalancerPutRequest.class));
     final var taskId = request.id;
     final var taskPhase = balancerConsole.taskPhase(taskId);
-    final var executorConfig = Configuration.of(request.executorConfig);
+    final var executorConfig = new Configuration(request.executorConfig);
     final var executor =
         Utils.construct(request.executor, RebalancePlanExecutor.class, executorConfig);
 
@@ -216,7 +216,7 @@ static PostRequestWrapper parsePostRequestWrapper(
 
     return new PostRequestWrapper(
         balancerPostRequest.balancer,
-        Configuration.of(balancerPostRequest.balancerConfig),
+        new Configuration(balancerPostRequest.balancerConfig),
         balancerPostRequest.parse(),
         currentClusterInfo);
   }

common/src/main/java/org/astraea/common/Configuration.java

@@ -18,90 +18,71 @@
 
 import java.time.Duration;
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.NoSuchElementException;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
-public interface Configuration {
+public record Configuration(Map<String, String> raw) {
 
-  Configuration EMPTY = Configuration.of(Map.of());
-
-  static Configuration of(Map<String, String> configs) {
-    return new Configuration() {
-      @Override
-      public Map<String, String> raw() {
-        return Collections.unmodifiableMap(configs);
-      }
-
-      @Override
-      public Optional<String> string(String key) {
-        return Optional.ofNullable(configs.get(key)).map(Object::toString);
-      }
-
-      @Override
-      public List<String> list(String key, String separator) {
-        return string(key).map(s -> Arrays.asList(s.split(separator))).orElseGet(List::of);
-      }
-    };
-  }
-
-  Map<String, String> raw();
+  public static final Configuration EMPTY = new Configuration(Map.of());
 
   /**
    * @param key the key whose associated value is to be returned
    * @return string value. never null
    */
-  Optional<String> string(String key);
+  public Optional<String> string(String key) {
+    return Optional.ofNullable(raw.get(Objects.requireNonNull(key)));
+  }
 
   /**
    * @param key the key whose associated value is to be returned
    * @return optional {@link Pattern} compiled from the string associated with the key. never null
    */
-  default Optional<Pattern> regexString(String key) {
+  public Optional<Pattern> regexString(String key) {
     return string(key).map(Pattern::compile);
   }
 
   /**
    * @param key the key whose associated value is to be returned
    * @return integer value. never null
    */
-  default Optional<Integer> integer(String key) {
+  public Optional<Integer> integer(String key) {
     return string(key).map(Integer::parseInt);
   }
 
-  default Optional<Long> longInteger(String key) {
+  public Optional<Long> longInteger(String key) {
     return string(key).map(Long::parseLong);
   }
 
   /**
    * @param key the key whose associated value is to be returned
    * @return duration value. If there is no key, return Optional.Empty
    */
-  default Optional<Duration> duration(String key) {
+  public Optional<Duration> duration(String key) {
     return string(key).map(Utils::toDuration);
   }
 
   /**
    * @param key the key whose associated value is to be returned
    * @return DataSize value. If there is no key, return Optional.Empty
    */
-  default Optional<DataSize> dataSize(String key) {
+  public Optional<DataSize> dataSize(String key) {
     return string(key).map(DataSize::of);
   }
 
-  default int requireInteger(String key) {
+  public int requireInteger(String key) {
     return integer(key).orElseThrow(() -> new NoSuchElementException(key + " is nonexistent"));
   }
 
   /**
    * @param key the key whose associated value is to be returned
    * @return string value. never null
    */
-  default String requireString(String key) {
+  public String requireString(String key) {
     return string(key).orElseThrow(() -> new NoSuchElementException(key + " is nonexistent"));
   }
 
@@ -110,8 +91,8 @@ default String requireString(String key) {
    * @return new Configuration only contains which the key value starts with the prefix, and the
    *     prefix string and the following dot will be removed from the key
    */
-  default Configuration filteredPrefixConfigs(String prefix) {
-    return of(
+  public Configuration filteredPrefixConfigs(String prefix) {
+    return new Configuration(
         raw().entrySet().stream()
             .filter(k -> k.getKey().startsWith(prefix))
             .collect(
@@ -124,5 +105,7 @@ default Configuration filteredPrefixConfigs(String prefix) {
    * @param separator to split string to multiple strings
    * @return string list. never null
    */
-  List<String> list(String key, String separator);
+  public List<String> list(String key, String separator) {
+    return string(key).map(s -> Arrays.asList(s.split(separator))).orElseGet(List::of);
+  }
 }

common/src/main/java/org/astraea/common/assignor/Assignor.java

@@ -161,7 +161,7 @@ public final GroupAssignment assign(Cluster metadata, GroupSubscription groupSub
   @Override
   public final void configure(Map<String, ?> configs) {
     this.config =
-        Configuration.of(
+        new Configuration(
             configs.entrySet().stream()
                 .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().toString())));
     var costFunctions =

common/src/main/java/org/astraea/common/balancer/AlgorithmConfig.java

@@ -184,7 +184,7 @@ public Builder timeout(Duration timeout) {
     }
 
     public AlgorithmConfig build() {
-      var config = Configuration.of(balancerConfig);
+      var config = new Configuration(balancerConfig);
 
       return new AlgorithmConfig() {
         @Override

common/src/main/java/org/astraea/common/balancer/BalancerProblemFormat.java

@@ -55,7 +55,7 @@ public AlgorithmConfig parse() {
 
   private HasClusterCost clusterCost() {
     if (clusterCosts.isEmpty()) throw new IllegalArgumentException("clusterCosts is not specified");
-    var config = Configuration.of(costConfig);
+    var config = new Configuration(costConfig);
     return HasClusterCost.of(
         Utils.costFunctions(
             clusterCosts.stream()
@@ -65,7 +65,7 @@ private HasClusterCost clusterCost() {
   }
 
   private HasMoveCost moveCost() {
-    var config = Configuration.of(costConfig);
+    var config = new Configuration(costConfig);
     var cf = Utils.costFunctions(moveCosts, HasMoveCost.class, config);
     return HasMoveCost.of(cf);
   }

common/src/main/java/org/astraea/common/cost/RecordSizeCost.java

@@ -33,7 +33,7 @@ public class RecordSizeCost
   public static final String MAX_MIGRATE_SIZE_KEY = "max.migrated.size";
 
   public RecordSizeCost() {
-    this.config = Configuration.of(Map.of());
+    this.config = new Configuration(Map.of());
   }
 
   public RecordSizeCost(Configuration config) {

common/src/main/java/org/astraea/common/cost/ReplicaLeaderCost.java

@@ -34,7 +34,7 @@ public class ReplicaLeaderCost implements HasBrokerCost, HasClusterCost, HasMove
   public static final String MAX_MIGRATE_LEADER_KEY = "max.migrated.leader.number";
 
   public ReplicaLeaderCost() {
-    this.config = Configuration.of(Map.of());
+    this.config = new Configuration(Map.of());
   }
 
   public ReplicaLeaderCost(Configuration config) {

common/src/main/java/org/astraea/common/cost/ReplicaLeaderSizeCost.java

@@ -39,7 +39,7 @@ public class ReplicaLeaderSizeCost
   public static final String MOVED_LEADER_SIZE = "moved leader size (bytes)";
 
   public ReplicaLeaderSizeCost() {
-    this.config = Configuration.of(Map.of());
+    this.config = new Configuration(Map.of());
   }
 
   public ReplicaLeaderSizeCost(Configuration config) {

common/src/main/java/org/astraea/common/cost/ReplicaNumberCost.java

@@ -32,7 +32,7 @@ public class ReplicaNumberCost implements HasClusterCost, HasMoveCost {
   private final Configuration config;
 
   public ReplicaNumberCost() {
-    this.config = Configuration.of(Map.of());
+    this.config = new Configuration(Map.of());
   }
 
   public ReplicaNumberCost(Configuration config) {

common/src/main/java/org/astraea/common/partitioner/Partitioner.java

@@ -141,7 +141,7 @@ private static class Interdependent {
   @Override
   public final void configure(Map<String, ?> configs) {
     var config =
-        Configuration.of(
+        new Configuration(
             configs.entrySet().stream()
                 .collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().toString())));
     config.string(ProducerConfigs.BOOTSTRAP_SERVERS_CONFIG).ifPresent(s -> admin = Admin.of(s));

common/src/test/java/org/astraea/common/ConfigurationTest.java

@@ -26,27 +26,27 @@ public class ConfigurationTest {
 
   @Test
   void testString() {
-    var config = Configuration.of(Map.of("key", "value"));
+    var config = new Configuration(Map.of("key", "value"));
     Assertions.assertEquals(Optional.of("value"), config.string("key"));
     Assertions.assertEquals("value", config.requireString("key"));
   }
 
   @Test
   void testList() {
-    var config = Configuration.of(Map.of("key", "v0,v1"));
+    var config = new Configuration(Map.of("key", "v0,v1"));
     Assertions.assertEquals(List.of("v0", "v1"), config.list("key", ","));
     Assertions.assertEquals(List.of(), config.list("nonExistKey", ","));
   }
 
   @Test
   void testFilteredConfigs() {
-    var config = Configuration.of(Map.of("key", "v1", "filtered.key", "v2", "key.filtered", "v3"));
+    var config = new Configuration(Map.of("key", "v1", "filtered.key", "v2", "key.filtered", "v3"));
     Assertions.assertEquals(Map.of("key", "v2"), config.filteredPrefixConfigs("filtered").raw());
   }
 
   @Test
   void testDuration() {
-    var config = Configuration.of(Map.of("wait.time", "15ms", "response", "3s"));
+    var config = new Configuration(Map.of("wait.time", "15ms", "response", "3s"));
     var waitTime = config.duration("wait.time");
     var response = config.duration("response");
     var empty = config.duration("walala");
@@ -57,13 +57,13 @@ void testDuration() {
 
   @Test
   void testLong() {
-    var config = Configuration.of(Map.of("long.value", "2147483648"));
+    var config = new Configuration(Map.of("long.value", "2147483648"));
     Assertions.assertEquals(2147483648L, config.longInteger("long.value").orElse(0L));
   }
 
   @Test
   void testDataSize() {
-    var config = Configuration.of(Map.of("upper.bound", "30MiB", "traffic.interval", "5MB"));
+    var config = new Configuration(Map.of("upper.bound", "30MiB", "traffic.interval", "5MB"));
     var upper = config.dataSize("upper.bound");
     var interval = config.dataSize("traffic.interval");
     var empty = config.dataSize("kekw");

common/src/test/java/org/astraea/common/DistributionTypeTest.java

@@ -88,7 +88,7 @@ void testZipfianConfig() {
     // fixed seed
     var zip100 =
         DistributionType.ZIPFIAN.create(
-            10000, Configuration.of(Map.of(DistributionType.ZIPFIAN_SEED, "100")));
+            10000, new Configuration(Map.of(DistributionType.ZIPFIAN_SEED, "100")));
     Assertions.assertEquals(
         List.of(11, 18, 0, 1126, 12),
         IntStream.range(0, 5)
@@ -101,21 +101,25 @@ void testZipfianConfig() {
     var seed = ThreadLocalRandom.current().nextInt();
     var zipA =
         DistributionType.ZIPFIAN.create(
-            10000, Configuration.of(Map.of(DistributionType.ZIPFIAN_SEED, Integer.toString(seed))));
+            10000,
+            new Configuration(Map.of(DistributionType.ZIPFIAN_SEED, Integer.toString(seed))));
     var zipB =
         DistributionType.ZIPFIAN.create(
-            10000, Configuration.of(Map.of(DistributionType.ZIPFIAN_SEED, Integer.toString(seed))));
+            10000,
+            new Configuration(Map.of(DistributionType.ZIPFIAN_SEED, Integer.toString(seed))));
     var sequenceA = IntStream.range(0, 1000).map(i -> zipA.get().intValue()).toArray();
     var sequenceB = IntStream.range(0, 1000).map(i -> zipB.get().intValue()).toArray();
     Assertions.assertArrayEquals(sequenceA, sequenceB);
 
     // high exponent come with high skewness
     var zip1 =
         DistributionType.ZIPFIAN.create(
-            100, Configuration.of(Map.of(DistributionType.ZIPFIAN_EXPONENT, Double.toString(1.0))));
+            100,
+            new Configuration(Map.of(DistributionType.ZIPFIAN_EXPONENT, Double.toString(1.0))));
     var zip2 =
         DistributionType.ZIPFIAN.create(
-            100, Configuration.of(Map.of(DistributionType.ZIPFIAN_EXPONENT, Double.toString(2.0))));
+            100,
+            new Configuration(Map.of(DistributionType.ZIPFIAN_EXPONENT, Double.toString(2.0))));
     var counting1 =
         IntStream.range(0, 10000)
             .map(x -> zip1.get().intValue())

common/src/test/java/org/astraea/common/UtilsTest.java

@@ -206,7 +206,7 @@ public int value() {
   @ParameterizedTest
   @ValueSource(classes = {TestCostFunction.class, TestConfigCostFunction.class})
   void testConstruct(Class<? extends CostFunction> aClass) {
-    var config = Configuration.of(Map.of());
+    var config = new Configuration(Map.of());
 
     var costFunction = Utils.construct(aClass, config);
     Assertions.assertInstanceOf(CostFunction.class, costFunction);
@@ -226,7 +226,7 @@ void testConstruct(Class<? extends CostFunction> aClass) {
   void testConstructException() {
     // arrange
     var aClass = TestBadCostFunction.class;
-    var config = Configuration.of(Map.of());
+    var config = new Configuration(Map.of());
 
     // act, assert
     Assertions.assertThrows(RuntimeException.class, () -> Utils.construct(aClass, config));
@@ -283,7 +283,7 @@ public TestBadCostFunction(int value) {}
   @Test
   void testCostFunctions() {
     var config =
-        Configuration.of(
+        new Configuration(
             Map.of(
                 "org.astraea.common.cost.BrokerInputCost",
                 "20",
@@ -307,7 +307,7 @@ void testCostFunctions() {
 
     // test negative weight
     var config2 =
-        Configuration.of(
+        new Configuration(
             Map.of(
                 "org.astraea.common.cost.BrokerInputCost",
                 "-20",
@@ -321,7 +321,7 @@ void testCostFunctions() {
     var cf =
         Set.of(
             "org.astraea.common.cost.RecordSizeCost", "org.astraea.common.cost.ReplicaLeaderCost");
-    var mConfig = Configuration.of(Map.of("maxMigratedSize", "50MB", "maxMigratedLeader", "5"));
+    var mConfig = new Configuration(Map.of("maxMigratedSize", "50MB", "maxMigratedLeader", "5"));
     var mAns = Utils.costFunctions(cf, HasMoveCost.class, mConfig);
     Assertions.assertEquals(2, mAns.size());
 

common/src/test/java/org/astraea/common/balancer/BalancerTest.java

@@ -168,7 +168,7 @@ public ClusterCost clusterCost(ClusterInfo clusterInfo, ClusterBean clusterBean)
               .toCompletableFuture()
               .join();
       var newAllocation =
-          Utils.construct(theClass, Configuration.of(Map.of("iteration", "500")))
+          Utils.construct(theClass, new Configuration(Map.of("iteration", "500")))
               .offer(
                   AlgorithmConfig.builder()
                       .clusterInfo(clusterInfo)
@@ -285,7 +285,7 @@ public ClusterCost clusterCost(ClusterInfo clusterInfo, ClusterBean clusterBean)
                   return () -> 0;
                 }
               };
-          Utils.construct(theClass, Configuration.of(Map.of("iteration", "500")))
+          Utils.construct(theClass, new Configuration(Map.of("iteration", "500")))
               .offer(
                   AlgorithmConfig.builder()
                       .clusterInfo(ClusterInfo.empty())