[SERIALIZATION] Serialize Borker info in Clusterinfo #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
May 10, 2023
common/src/main/proto/org/astraea/common/generated/ClusterInfo.proto
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 11, 2023
chaohengstudent
commented
May 12, 2023
common/src/test/java/org/astraea/common/admin/ClusterInfoBuilderTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # common/src/main/java/org/astraea/common/admin/Config.java
# Conflicts: # common/src/main/java/org/astraea/common/ByteUtils.java # common/src/main/java/org/astraea/common/admin/Broker.java # common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java # common/src/test/java/org/astraea/common/ByteUtilsTest.java # common/src/test/java/org/astraea/common/admin/ClusterInfoBuilderTest.java
chia7712
reviewed
May 25, 2023
common/src/main/proto/org/astraea/common/generated/admin/Broker.proto
Outdated
Show resolved
Hide resolved
|
麻煩修正一下衝突，謝謝 |
# Conflicts: # common/src/main/java/org/astraea/common/ByteUtils.java
|
unrelated test failed track by #1784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1704
此 pr 將
Broker資訊序列化以確保能夠得到Broker設定為了實現比較
Broker的方法，目前的作法是透過BrokerImpl,DataFolderImpl這兩個 recordConfig的equals()