Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon tint fix #3706

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Icon tint fix #3706

wants to merge 7 commits into from

Conversation

hilpitome
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@hilpitome hilpitome requested a review from ellykits January 27, 2025 16:17
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 38.0%. Comparing base (1542bb7) to head (526768f).

Files with missing lines Patch % Lines
...ister/fhircore/quest/ui/shared/components/Image.kt 0.0% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3706     +/-   ##
=========================================
+ Coverage     37.9%   38.0%   +0.1%     
+ Complexity    1157    1150      -7     
=========================================
  Files          287     287             
  Lines        15504   15299    -205     
  Branches      2730    2695     -35     
=========================================
- Hits          5884    5822     -62     
+ Misses        8776    8648    -128     
+ Partials       844     829     -15     
Flag Coverage Δ
engine 60.8% <ø> (ø)
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ister/fhircore/quest/ui/shared/components/Image.kt 0.0% <0.0%> (ø)

... and 19 files with indirect coverage changes

@f-odhiambo
Copy link
Contributor

Hey @hilpitome this PR is not working as expected, do we have some working configs and also can you share some screenshots ?

@hilpitome
Copy link
Contributor Author

hilpitome commented Feb 20, 2025

Hey @hilpitome this PR is not working as expected, do we have some working configs and also can you share some screenshots ?

@f-odhiambo Checkout the following screenshots. I am testing with a debug version of contigo. Precisely the Past Child follow up visit config. I changed the hex color to red in the second image
checkbox
after

@hilpitome hilpitome enabled auto-merge February 20, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants