Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to fix mistakenly caught IllegalStateException #3724

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Mar 4, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes some of the tests errors thrown to STANDARD_ERROR when running ci

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.9%. Comparing base (1542bb7) to head (c49f84e).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3724   +/-   ##
=======================================
  Coverage     37.9%   37.9%           
+ Complexity    1157    1153    -4     
=======================================
  Files          287     287           
  Lines        15504   15442   -62     
  Branches      2730    2719   -11     
=======================================
- Hits          5884    5865   -19     
+ Misses        8776    8738   -38     
+ Partials       844     839    -5     
Flag Coverage Δ
engine 60.7% <ø> (-0.1%) ⬇️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 6.3% <ø> (+0.1%) ⬆️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 66.7% <ø> (-0.1%) ⬇️
...t/ui/sdc/qrCode/EditTextQrCodeViewHolderFactory.kt 61.9% <ø> (+0.9%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant