Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEREF_AFTER_NULL in mm_answer_keyallowed() #469

Closed
wants to merge 1 commit into from
Closed

Fix DEREF_AFTER_NULL in mm_answer_keyallowed() #469

wants to merge 1 commit into from

Conversation

maks-mishin
Copy link

After having been compared to a NULL value at monitor.c:1206, pointer 'key' is dereferenced in function auth2_record_key.

Found by RASU JSC.

@djmdjm
Copy link
Contributor

djmdjm commented Mar 30, 2024

key=NULL is impossible here as sshkey_froms() won't return a NULL key. I'll look at removing the unnecessary key==NULL checks instead

@maks-mishin maks-mishin reopened this Apr 26, 2024
@maks-mishin maks-mishin closed this by deleting the head repository Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants