-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bobcat 2023.2/candidate channels #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freyes
previously requested changes
Oct 11, 2023
fnordahl
reviewed
Oct 12, 2023
- 2023.2/candidate | ||
bases: | ||
- "22.04" | ||
- "23.10" | ||
|
||
# - name: OpenStack Neutron Dynamic Routing Charm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A rebase is needed after #40 merged, it provided a commented out section for the stable channel, which I guess can be uncommented as part of this PR
ajkavanagh
dismissed
freyes’s stale review
October 18, 2023 11:31
Resolved the issue; switched to 2.x/stable.
Add the bobcat 2023.2 channes for the OpenStack charms. The recipe is to push to /candidate for SQA to consume prior to releasing to stable. Bug fixes during the testing period will therefore be pushed to /candidate to assist with simplified testing of any fixes. The charmcraft 2.2/stable channel has been selected for the recipes as that is the latest stable channel availble for long term building of the bobcat charms. Bases 22.04 and 23.10 have been selected to support jammy and mantic.
This is to support mantic binary builds which will only be available in 2.4+ when they do become available. There is no 2.4 channel for charmcraft so it's have to be on 2.x/stable for the moment.
neutron-dynamic-routing has been added back in, so also add in a bobcat stable version.
ajkavanagh
force-pushed
the
add-bobcat-candidate
branch
from
October 18, 2023 11:45
23ceb8b
to
89e6fb2
Compare
Blocked by canonical/charmcraft#1354 |
This is to ensure that we updates more quickly for the charmcraft on the master/main and stable/2023.2 branches.
freyes
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the bobcat 2023.2 channes for the OpenStack charms. The recipe is to
push to /candidate for SQA to consume prior to releasing to stable. Bug
fixes during the testing period will therefore be pushed to /candidate
to assist with simplified testing of any fixes.
The charmcraft 2.2/stable channel has been selected for the recipes as
that is the latest stable channel availble for long term building of the
bobcat charms.
Bases 22.04 and 23.10 have been selected to support jammy and mantic.