Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cinder-nfs charm #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

qch2012
Copy link

@qch2012 qch2012 commented Aug 6, 2024

No description provided.

Copy link
Contributor

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the entry requires a branches override to limit the releases for the charm to something more recent than bionic-train.

Comment on lines 1000 to 1004
- name: OpenStack Cinder NFS Charm
charmhub: cinder-nfs
launchpad: charm-cinder-nfs
repository: https://opendev.org/openstack/charm-cinder-nfs.git

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note that this is probably wrong, in that it doesn't include a branches override. It's unlikely that this charm needs to go back to bionic-train. Please select appropriate branches for this charm.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added branch override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants