update requirements #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajkavanagh
commented
Nov 6, 2023
ajkavanagh
commented
- Add 'print-revisions' command
- Switch typing '|' to Union
- Update requirements with new format for git
The 'print-revisions' command prints out a set or revision numbers for projects from charmed-openstack-info. The can be filtered according to bases, channels and architectures. This is handy to find a set of revisions that supports a particular base/arch in a channel.
Py3.9 and before doesn't understand the "type | type" form.
Update the requirements.txt with the new module @ git... format for python-apt that works much better with pip 22+; this is so that pip *doesn't* go to pypi to try to resolve the module if it doesn't 'match' as the module is more formally defined (although it might just be a bug in pip). Also bump python-apt to 2.5.3 tag as that's the latest version.
ajkavanagh
force-pushed
the
update-requirements
branch
from
2b2a9aa to
704d676
Compare
|
My understanding is that this PR has been superseeded by #38 , so I'm closing it, if I'm wrong, please reopen. |
|
I think it got mixed up with another patch, but the change to requirements was probably needed. I'll add it back into my next patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.