[DNM] Fix ipv6 condition #2682
[DNM] Fix ipv6 condition #2682
Conversation
gthiemonge
requested review from
pablintino,
lewisdenny,
evallesp,
bshewale and
frenzyfriday
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5172945efa9f4e5a800f969a96abb859 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 44m 59s |
| ternary(ansible_facts[_name].ipv6 | | ||
| selectattr('scope', 'equalto', 'global') | first, {}) | ||
| }} | ||
| {% if ansible_facts[_name].ipv6 is defined -%} |
There was a problem hiding this comment.
What issue are you fixing?
There is no information in the commit message, no link to issue/jira ticket explaining what the problem is.
To me, it looks like you are doing the same thing using a different "style"? If there was a commit message explaining what/why I probably would not have needed to ask these questions. :)
There was a problem hiding this comment.
it's just a DNM patch that tries to fix an issue I have in my env.
It looks like the syntax: "var is defined| ternary(var, other_var)" is not correct because ternary always evaluates both parameters.
The patch works for me now, but I'm not sure it covers all the cases
I'll remove the DNM tag if I find a clear/better solution
There was a problem hiding this comment.
Shifting to draft status due to this comment @gthiemonge , please update the PR is anything changes :)
|
This PR is stale because it has been for over 15 days with no activity. |
No description provided.