Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package whitelist for auto-cleanup function #809

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add package whitelist for auto-cleanup function #809

wants to merge 5 commits into from

Conversation

thinkhy
Copy link
Member

@thinkhy thinkhy commented Feb 20, 2018

Add an option '--white-list-file' in provider. The packages specified in white list file will not be auto-cleanup between uses.

@sorccu
Copy link
Member

sorccu commented Feb 20, 2018

Seems usable for some but we specifically chose to not do something like this at the time STF was built, as we found that on many devices it was possible to uninstall some of the bundled applications but there was no clear way of getting them back once uninstalled. It would have been way too risky in Japan where carrier customization was and is quite heavy.

I’m ok with having this feature, however it should be off by default and should not output a warning message if not used.

@thinkhy
Copy link
Member Author

thinkhy commented Feb 21, 2018

@sorccu Thanks for your reviewing. I've just adjusted my code to set the default value of white list file to empty and remove the warning msg. Now the feature is turned off by default and output the msg "Loading the white list file xxx" only if white list file is specified(Non-empty) and existed. Also I added a argument '--white-list-file' in cli/local/index.js to make test and debug easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants