Fix map blink when active Mapnik + some overlay #5570
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5474 added an unpleasant blink when an overlay is enabled and Mapnik is base layer, and you try to close the sidebar:
blick.mp4
This is because
var layers = layerParam || "M";
does not addM
when overlay is enabled (layerParam
is not empty). I added a check that if Mapnik is the current layer, then we add its code, so that.removeLayer()
was not called for it.Checking
this.getMapbaslaver() &&
is important because when opening the tab it can returnundefined
.