Fix #15 - Improve developer README for openstudioreleases #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmarrec
commented
Sep 23, 2024
jmarrec
commented
- Fix Improve README for openstudioreleases #15
jmarrec
commented
Sep 23, 2024
Comment on lines
+118
to
+122
| For it to work, you need the `firebase-service-account.json` with the private key next to this README.md (Ask the maintainers). | ||
|
|
||
| To generate one you will need to go to the [Firebase project Service Accounts settings](https://console.firebase.google.com/u/0/project/osc-downloads/settings/serviceaccounts/adminsdk) | ||
|
|
||
| Generate a new private key, and save it to `firebase-service-account.json`. **Note: as soon as you generate a new private key, the old key will stop working, so ask the maintainers to provide it instead** |
There was a problem hiding this comment.
@macumber please review this carefully... (also, do you have that json file to share with me?)
openstudioreleases/README.md
Outdated
Comment on lines
111
to
177
| # TODO: explain this | ||
|
|
||
| set `.env.prd` for production build No newline at end of file | ||
| set `.env.prd` for production build |
There was a problem hiding this comment.
- TODO: I don't get that one
|
|
||
| ### Google Analytics | ||
|
|
||
| Set the `GA_ID` in the `.env` file. This is the Measurement ID for the OS App website itself (OS App Git - GA4) |
There was a problem hiding this comment.
@macumber I am not sure at all this is right. #15 (comment)
macumber
reviewed
Sep 24, 2024
macumber
reviewed
Sep 24, 2024
macumber
reviewed
Sep 24, 2024
| FIREBASE_MEASUREMENT_ID= | ||
| GA_ID= |
There was a problem hiding this comment.
I don't have a GA_ID in the .env file, I think you just enter FIREBASE_MEASUREMENT_ID and that links to Google Analytics
There was a problem hiding this comment.
$ cd openstudioreleases && rg GA_ID
src/index.tsx
15:if (config.GA_ID) {
16: ReactGA.initialize(config.GA_ID);
src/config.tsx
2: GA_ID: process.env.GA_ID,
src/ga/usePageView.tsx
15: if (!process.env.GA_ID)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.