chore(l2g): make shap optional #1012
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-defiant
approved these changes
Mar 3, 2025
| @@ -292,9 +295,11 @@ def run_predict(self) -> None: | |||
| hf_token=access_gcp_secret("hfhub-key", "open-targets-genetics-dev"), | |||
| download_from_hub=self.download_from_hub, | |||
| ) | |||
| if self.explain_predictions: | |||
| predictions = predictions.explain() | |||
| predictions.filter(f.col("score") >= self.l2g_threshold).add_features( | |||
There was a problem hiding this comment.
Honest question. Can we calculate shap values after filtering ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
In order to evaluate the latest model, I want to run the predictions step without extracting SHAPs.
I've tested this works in this job.
🛠 What does this PR implement
explain_predictions(set to False by default) as a parameter to the L2G step🙈 Missing
🚦 Before submitting
devbranch?make test)?uv run pre-commit run --all-files)?