-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: devcontainer development environment #487
base: dev
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
@ireneisdoomed and @DSuveges, I tagged you both here but only in case you have the time. I think this doesn't clash with any current functionality and it's optional so it's not a big priority. The thing to look at could be to start a devcontainer yourselves (whenever you have something to-do) and confirm things are mostly working for you. You can look at the requested changes in the documentation for more info. |
The only extra requirements were:
Update:
Update 2: After thinking about this for a little longer, I realised it doesn't make much sense. The point of using dataproc is to use the dataproc environment. By using a devcontainer you isolate the development from the Dataproc capabilities. There is a longer route, which is creating a dataproc custom image. I think it's a different type of endeavour to the one attempted here. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
So is this going to be merged? To me it seems having dev containers won't provide much benefit compared to using poetry managed environment when working local. And dataproc based remote work won't be facilitatad by the current implementation. |
for more information, see https://pre-commit.ci
We have people in the team without a properly set environment. The entry point to start developing still requires a decent amount of investment. Everything about Because it's optional, if there is not enough adoption it defeats the purpose. IMO the benefits outweigh the risks, but we won't know unless we test in real-world scenarios. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@d0choa what is the status of this PR? Is it still relevant? |
I wouldn't close it. It's not a priority, but it has a lot of good things we could eventually rescue |
This PR allows to setup a development environment using the devcontainer stragety. More info...
A few working functionalities:
github-cli
and git credentials within devcontainer (mounted from local)google-cloud-cli
and gcp credentials within devcontainer (mounted from local)Here are a few things I haven't fully tested or might be material for future work:
Run devcontainer inside dataproc cluster.Hint~~Feedback welcomed