Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: Phewas and Manhattan plot fixes #601

Merged
merged 2 commits into from
Dec 9, 2024
Merged

[Platform]: Phewas and Manhattan plot fixes #601

merged 2 commits into from
Dec 9, 2024

Conversation

gjmcn
Copy link
Contributor

@gjmcn gjmcn commented Dec 9, 2024

Description

Fixes for Manhattan plot (study page) and PheWas plot (variant page):

  • Both plots

    • switch to computing y values directly and using linear y-scale in plots - very small p-values (less thanNumber.MIN_NUMBER) and use of log scales was causing various issues
    • use dominant-baseline instead of alignment-baseline with labels for consistent behavior across browsers
  • Phewas plot:

    • update margins
    • edit therapeutic area labels so shorter (after discussion with @d0choa)
    • fix bug with uncategorised values in PheWas plot
    • add legend

Issue: #3537, #3502

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checked no study and variant pages.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

@carcruz carcruz merged commit 7e2cebf into main Dec 9, 2024
11 checks passed
@carcruz carcruz deleted the gm-plots-fixes branch December 9, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants