Initial commit for Typer (wallet commands) #1

thewhaleking · 2024-07-25T19:21:51Z

Initial commit for review. All of the wallet commands and config are done/working. There is a delegates command (list) in there as a skeleton, but it is not implemented.

… us to actually decode the SCALE objects. Refactored the logic of wallet balance to be faster.

…se of block hash in AsyncSubstrateInterface.

…r CLI.

thewhaleking · 2024-08-02T20:18:59Z

Config doesn't work well if chain is set, but you want to use a predefined network. This is largely due to the way that the chain endpoint is set in SubtensorInterface.

This is fixed in #3

gus-opentensor

🔥

roman-opentensor

We have developed and approved the Bittensor Coding Standards. As a programmer, I find it more comfortable to read code that adheres to all aspects of these standards.

I noticed that the docstrings for functions and classes are written in different styles. I suggest contacting Raj to clarify the style used for documentation generation. This will help significantly reduce the time spent on documentation, unify the codebase, and improve code readability.

Overall, I really liked the implementation. Great job!

roman-opentensor · 2024-08-05T18:32:12Z

cli.py

@@ -0,0 +1,1263 @@
+#!/usr/bin/env python3


Will this file be a script in the future?

cli.py

roman-opentensor · 2024-08-05T18:33:52Z

cli.py

+        raise typer.Exit()
+
+
+class CLIManager:


pls describe the purpose of the class

roman-opentensor · 2024-08-05T20:41:03Z

src/bittensor/async_substrate_interface.py

+            return message, bool_result
+        return obj, True
+
+    async def _make_rpc_request(


pls add docstring

roman-opentensor · 2024-08-05T20:42:23Z

src/__init__.py

+from dataclasses import dataclass
+
+
+class Constants:


pls describe the class

roman-opentensor · 2024-08-05T20:42:49Z

src/__init__.py

+
+
+@dataclass
+class DelegatesDetails:


pls describe the class

roman-opentensor · 2024-08-05T20:42:55Z

src/__init__.py

+        )
+
+
+class Defaults:


pls describe the class

cli.py

* `root list` working * Fixed help output * Fixed help output * Fixed the way config for network/chain is handled. * [WIP] Check-in. Pausing on setting weights until I determine whether we're doing the metagraph approach still. * Root get-weights * Circular import temp fix. * Added root boost command. Not finished as I need to confirm the use of metagraph on it. * Ruff * Root boost and root set-weights. * Code cleanup. * Code cleanup. * Feedback from PR #1 * Feedback from PR #1. Docstrings mostly. * Final PR #1 suggestions I will be implementing. * In the arena, trying things. * Boost and Slash created with new logic to parse old weights. Confirming this logic is correct in Discord. * Senate vote added * Added `root senate` command. * Root register command. * Root proposals * Root `set-take` * Root `set-delegate` * Root `undelegate-stake` * Docstring. * [WIP] Check-in * [WIP] Check-in * Root `my-delegates` * Root `list-delegates` * Root `nominate`, made extrinsics more general for signing and such. * Ruff and Mypy * Ruff and Mypy * Corrected type registry change.

* `root list` working * Fixed help output * Fixed help output * Fixed the way config for network/chain is handled. * [WIP] Check-in. Pausing on setting weights until I determine whether we're doing the metagraph approach still. * Root get-weights * Circular import temp fix. * Added root boost command. Not finished as I need to confirm the use of metagraph on it. * Ruff * Root boost and root set-weights. * Code cleanup. * Code cleanup. * Feedback from PR #1 * Feedback from PR #1. Docstrings mostly. * Final PR #1 suggestions I will be implementing. * In the arena, trying things. * Boost and Slash created with new logic to parse old weights. Confirming this logic is correct in Discord. * Senate vote added * Added `root senate` command. * Root register command. * Root proposals * Root `set-take` * Root `set-delegate` * Root `undelegate-stake` * Docstring. * [WIP] Check-in * [WIP] Check-in * Root `my-delegates` * Root `list-delegates` * Root `nominate`, made extrinsics more general for signing and such. * Ruff and Mypy * Ruff and Mypy * [WIP] Initial Commit for stake commands. * `stake show` command working. * Root commands (#3) * `root list` working * Fixed help output * Fixed help output * Fixed the way config for network/chain is handled. * [WIP] Check-in. Pausing on setting weights until I determine whether we're doing the metagraph approach still. * Root get-weights * Circular import temp fix. * Added root boost command. Not finished as I need to confirm the use of metagraph on it. * Ruff * Root boost and root set-weights. * Code cleanup. * Code cleanup. * Feedback from PR #1 * Feedback from PR #1. Docstrings mostly. * Final PR #1 suggestions I will be implementing. * In the arena, trying things. * Boost and Slash created with new logic to parse old weights. Confirming this logic is correct in Discord. * Senate vote added * Added `root senate` command. * Root register command. * Root proposals * Root `set-take` * Root `set-delegate` * Root `undelegate-stake` * Docstring. * [WIP] Check-in * [WIP] Check-in * Root `my-delegates` * Root `list-delegates` * Root `nominate`, made extrinsics more general for signing and such. * Ruff and Mypy * Ruff and Mypy * Corrected type registry change. * `stake show` command working. * `stake get-children` command * `stake set-children` command * Added commands to stake_app * Exception handling and printing. * Close subtensor. * Added TODOs * Fixed the list options in CLI. Began adding stake command. * Update requirements.txt to use SSH instead of HTTPS for easier cloning * Fixed interactive prompting and mypy issues. * Fixed interactive prompting and mypy issues. * Removed _take_extrinsic logic to the subtensor.sign_and_send_extrinsic method. Added the actual logic for doing the `root set-weights` command to its respective CLI command. * Mypy * `stake add` command * Fixed vecu8 * `stake show` command * PR Feedback — added docstrings.

* `root list` working * Fixed help output * Fixed help output * Fixed the way config for network/chain is handled. * [WIP] Check-in. Pausing on setting weights until I determine whether we're doing the metagraph approach still. * Root get-weights * Circular import temp fix. * Added root boost command. Not finished as I need to confirm the use of metagraph on it. * Ruff * Root boost and root set-weights. * Code cleanup. * Code cleanup. * Feedback from PR #1 * Feedback from PR #1. Docstrings mostly. * Final PR #1 suggestions I will be implementing. * In the arena, trying things. * Boost and Slash created with new logic to parse old weights. Confirming this logic is correct in Discord. * Senate vote added * Added `root senate` command. * Root register command. * Root proposals * Root `set-take` * Root `set-delegate` * Root `undelegate-stake` * Docstring. * [WIP] Check-in * [WIP] Check-in * Root `my-delegates` * Root `list-delegates` * Root `nominate`, made extrinsics more general for signing and such. * Ruff and Mypy * Ruff and Mypy * Corrected type registry change.

Initial commit for Typer

ae234bf

thewhaleking self-assigned this Jul 25, 2024

thewhaleking added 16 commits July 25, 2024 21:36

Removed wallet overwrite

4082ecf

Created mock Wallet object to develop, based on Roman's Wallet

e22ff36

ruff

99c104c

Added bittensor-wallet from repo

1f13cdb

Added defaults, utils; consolidated some reused code.

671feb0

Add wallet validation, clean up code.

90d6e8a

Use correct defaults.

5df5ceb

Updated docstrings.

36f772d

[WIP] Check-in

d7ffbdf

no op

ad8543e

no op

31b72a7

no op

e09436c

Added type registry to AsyncSubstrateInterface instantiation to allow…

9d8f076

… us to actually decode the SCALE objects. Refactored the logic of wallet balance to be faster.

Added spinner animation for wallet balance.

d4dbd7c

Reformatted table in wallet balance. Ran ruff.

7b7aa06

More wallet commands ported. Improved wallet validation. Improved reu…

16ea35e

…se of block hash in AsyncSubstrateInterface.

thewhaleking mentioned this pull request Jul 29, 2024

Port BTCLI Commands #2

Closed

7 tasks

thewhaleking linked an issue Jul 29, 2024 that may be closed by this pull request

Port BTCLI Commands #2

Closed

7 tasks

thewhaleking added 10 commits July 29, 2024 22:51

[WIP] Check-in. Overview working with all-but encrypted keys.

10e692e

Overview working with --all

d6c64a0

Ruff

d362322

TODO

d440fd7

Overview now correctly handles --all

cde8486

Async Substrate Interface performance improvements.

31d9483

Async Substrate Interface performance improvements. Error handling fo…

02e6fa3

…r CLI.

[WIP] Transfer almost finished.

ba95aca

aenter subtensor

6c7e68b

Wallet transfer finished.

060dca2

thewhaleking added 9 commits August 1, 2024 15:10

Sets timeout error catch for github pulling.

a9bcecb

Added config setter/getter. WIP on faucet.

e2848d8

Cleaned up Defaults class

84e4937

Formatting, cleanup, add requirements.

3afffec

Formatting

cf2f804

Renamed 'default' typer app to 'config' typer app. Faucet working.

7aae0f1

Ruff

c52d144

Config loading of wallets

df138e9

Swap hotkey added.

e09bf6c

thewhaleking marked this pull request as ready for review August 1, 2024 21:17

thewhaleking requested a review from a team August 1, 2024 21:17

Added get-identity and set-identity

4fb00cd

thewhaleking changed the title ~~Initial commit for Typer~~ Initial commit for Typer (wallet commands) Aug 2, 2024

thewhaleking added 4 commits August 2, 2024 15:57

Ruff

828fb68

Added wallet check-swap

382bafb

Versioning with branch name

33b21cb

Versioning with branch name

dca2d7a

gus-opentensor approved these changes Aug 5, 2024

View reviewed changes

thewhaleking merged commit a1733da into main Aug 5, 2024

thewhaleking deleted the experimental/thewhaleking/typer branch August 5, 2024 19:03

roman-opentensor requested changes Aug 5, 2024

View reviewed changes

thewhaleking added a commit that referenced this pull request Aug 6, 2024

Feedback from PR #1

b4c9b1f

thewhaleking added a commit that referenced this pull request Aug 6, 2024

Feedback from PR #1. Docstrings mostly.

c0abff9

thewhaleking added a commit that referenced this pull request Aug 6, 2024

Final PR #1 suggestions I will be implementing.

965bcea

ibraheem-opentensor mentioned this pull request Sep 25, 2024

Release 8.0.0 #119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial commit for Typer (wallet commands) #1

Initial commit for Typer (wallet commands) #1

thewhaleking commented Jul 25, 2024 •

edited

Loading

thewhaleking commented Aug 2, 2024 •

edited

Loading

gus-opentensor left a comment

roman-opentensor left a comment

roman-opentensor Aug 5, 2024

roman-opentensor Aug 5, 2024

roman-opentensor Aug 5, 2024

roman-opentensor Aug 5, 2024

roman-opentensor Aug 5, 2024

roman-opentensor Aug 5, 2024

Initial commit for Typer (wallet commands) #1

Initial commit for Typer (wallet commands) #1

Conversation

thewhaleking commented Jul 25, 2024 • edited Loading

thewhaleking commented Aug 2, 2024 • edited Loading

gus-opentensor left a comment

Choose a reason for hiding this comment

roman-opentensor left a comment

Choose a reason for hiding this comment

roman-opentensor Aug 5, 2024

Choose a reason for hiding this comment

roman-opentensor Aug 5, 2024

Choose a reason for hiding this comment

roman-opentensor Aug 5, 2024

Choose a reason for hiding this comment

roman-opentensor Aug 5, 2024

Choose a reason for hiding this comment

roman-opentensor Aug 5, 2024

Choose a reason for hiding this comment

roman-opentensor Aug 5, 2024

Choose a reason for hiding this comment

thewhaleking commented Jul 25, 2024 •

edited

Loading

thewhaleking commented Aug 2, 2024 •

edited

Loading