Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct min burn init #1265

Merged
merged 6 commits into from
Feb 7, 2025
Merged

use correct min burn init #1265

merged 6 commits into from
Feb 7, 2025

Conversation

camfairchild
Copy link
Contributor

No description provided.

@camfairchild camfairchild requested a review from unconst as a code owner February 7, 2025 19:48
@camfairchild camfairchild changed the title use correct min brun init use correct min burn init Feb 7, 2025
gztensor
gztensor previously approved these changes Feb 7, 2025
sam0x17
sam0x17 previously approved these changes Feb 7, 2025
@camfairchild camfairchild dismissed stale reviews from sam0x17 and gztensor via 013f014 February 7, 2025 19:57
@camfairchild camfairchild merged commit e3635ff into devnet-ready Feb 7, 2025
12 of 16 checks passed
garrett-opentensor pushed a commit that referenced this pull request Feb 13, 2025
* wait rate limit in tests

* use rem root alpha

* fix test involving alpha out emission

* fix alpha out expectation

* Ban to_num, organize safe math into a crate

* Avoid using from_num

* Fix zepter

* Fix zepter

* Invalidate staking and unstaking transactions if liquidity is inadequate

* Fix swap_alpha_for_tao

* Set DefaultMinimumPoolLiquidity

* add new fields to ChainIdentity and SubnetIdentity

* Fix test_do_move_max_values

* Add tests

* Fix unsafe math

* Update pallets/subtensor/src/staking/stake_utils.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* Update pallets/subtensor/src/staking/stake_utils.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* add migration and test

* make min burn only callable by root

* add tests for reg disable -> tao-in == 0

* disable TAO into subnet if reg are disabled

* add stake info by hk, ck, netuid

* Revert "add stake info by hk, ck, netuid"

This reverts commit e0e2b84.

* Add stakeinfo by hk, ck, netuid

* typo

* Replace frontier's RuntimeHelper with manual dispatcher

* add subnet volume to runtimeAPIs

* Move checked_sqrt to save math and add tests

* Change type for pool k to I110F18

* Raise minimum pool liquidity to 1 TAO

* Format

* Implement remove_stake_limit

* Fix clippy

* Fix tests

* Add an option to run try-runtime script with a snapshot

* Update spec version

* Add allow_partial parameter for add_stake_limit and remove_stake_limit

* Bump spec version to 225

* Update pallets/subtensor/src/tests/staking.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* Update pallets/subtensor/src/staking/remove_stake.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* refactor code

* fix cargo audit working in CI 🎉

* bump CI

* upgrade futures-util

* ignore some unmaintained advisories

* add another unmaintained

* cargo update url

* fix more advisories

* fix more advisories

* add len check

* add len check

* Fix rao migration did not update TotalIssuance

* Refactor TryState

* Reformat

* fix wrong origin

* fix clippy

* Implement slippage safe move_stake_limit

* Validate slippage-safe staking extrinsics

* fix some CI actions not triggering on newly opened pull request

* no owner dereg & tests

* update existing tests

* Double-size SubnetVolume to u128

* Add swap_stake_limit

* Add tests, fix corner case bugs

* commit Cargo.lock

* add comments

* fix wrong origin

* fix clippy

* Remove pallet-dynamic-fee and associated inherent data

* Add tests, fix bugs

* Cleanup

* Add subnet volume migration to fix try-runtime

* Revert endpoint change in try-runtime script

* Use resulting average price formula for add-remove limit stake

* commit Cargo.lock

* cargo clippy

* cargo fix

* safe math usage

* upgrade openssl

* address freeze_struct

* rename commit_reveal_period

* apply criticial openssl update to fix RUSTSEC-2025-0004 (openssl)

* remove subnet_info_v3

* address lint

* update register_network with identity precompile

* fix merge commit

* bump spec

* remove SubnetInfov3 struct

* rename emission_values => emission_value

* bump spec

* use saturating math

* add cleaned coinbase

* noclaim

* remove complexity

* non scaled tao emission

* bump

* fix test

* clean coinbase

* pre merge

* no tao in for non registration

* move to moving prices rather than tao reserves

* price

* moving alpha

* bump spec

* Fix tests

* add moving price tests

* add alpha in tests

* Fix all tests

* Format

* Fix unsafe math

* alpha tests

* set tao weight

* reset default staking fee

* fix names

* add mainnet names

* cargo clippy

* cargo fmt

* add a global min burn and migration

* add more tests for root pending etc

* alpha divs

* fix test for root

* new test root tao

* fix wrong parse function

* fix test

* add toggle off for transfers

* delete unused workflow file

* Fix validation for transfer toggle

* remove duplicate tests

* fix subnet creation logic

* cargo fmt

* add new test

* bump spec version to 228

* Add test test_drain_alpha_childkey_parentkey

* spec bump

* commit Cargo.lock

* cargo clippy

* cargo fmt

* fix min lock

* fmt

* fix migration test

* cargo fmt

* fix root

* cargo fmt

* add moving price to metagraph

* use correct min burn init (#1265)

* use correct min brun init

* fmt

* no into

* no into 2

* bump spec

* cargo update to fix cargo audit vulnerabilities

* bump spec version

* moving price init from emission

* cargo fmt

* bump spec version

* commit Cargo.lock

* cargo clippy

* cargo fmt

* DefaultMinimumPoolLiquidity and tempos in rao migration

---------

Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: Greg Zaitsev <[email protected]>
Co-authored-by: JohnReedV <[email protected]>
Co-authored-by: open-junius <[email protected]>
Co-authored-by: gztensor <[email protected]>
Co-authored-by: Aliaksandr Tsurko <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: unconst <[email protected]>
Co-authored-by: Unconst <[email protected]>
Co-authored-by: camfairchild <[email protected]>
garrett-opentensor pushed a commit that referenced this pull request Feb 16, 2025
* fix compile

* Remove pallet-dynamic-fee and associated inherent data

* Add tests, fix bugs

* Cleanup

* Add subnet volume migration to fix try-runtime

* Revert endpoint change in try-runtime script

* Use resulting average price formula for add-remove limit stake

* commit Cargo.lock

* cargo clippy

* cargo fix

* safe math usage

* upgrade openssl

* fix clippy

* address freeze_struct

* rename commit_reveal_period

* apply criticial openssl update to fix RUSTSEC-2025-0004 (openssl)

* remove subnet_info_v3

* address lint

* update register_network with identity precompile

* fix merge commit

* bump spec

* remove SubnetInfov3 struct

* rename emission_values => emission_value

* bump spec

* safe math

* remove duplicated function

* use saturating math

* add cleaned coinbase

* noclaim

* remove complexity

* non scaled tao emission

* bump

* fix test

* clean coinbase

* pre merge

* no tao in for non registration

* move to moving prices rather than tao reserves

* price

* moving alpha

* bump spec

* Fix tests

* add moving price tests

* add alpha in tests

* Fix all tests

* Format

* Fix unsafe math

* alpha tests

* set tao weight

* reset default staking fee

* fix names

* add mainnet names

* cargo clippy

* cargo fmt

* add a global min burn and migration

* add more tests for root pending etc

* alpha divs

* fix test for root

* new test root tao

* fix wrong parse function

* fix test

* add toggle off for transfers

* delete unused workflow file

* Fix validation for transfer toggle

* remove duplicate tests

* fix subnet creation logic

* cargo fmt

* add new test

* bump spec version to 228

* Add test test_drain_alpha_childkey_parentkey

* spec bump

* fix audit

* fix audit

* fix contract

* commit Cargo.lock

* cargo clippy

* cargo fmt

* fix min lock

* fmt

* fix migration test

* cargo fmt

* fix root

* cargo fmt

* add moving price to metagraph

* use correct min burn init (#1265)

* use correct min brun init

* fmt

* no into

* no into 2

* bump spec

* cargo update to fix cargo audit vulnerabilities

* bump spec version

* moving price init from emission

* cargo fmt

* bump spec version

* commit Cargo.lock

* cargo clippy

* cargo fmt

* DefaultMinimumPoolLiquidity and tempos in rao migration

* update readme of support of M series macs

* bump runtime version

* add tao_emission to stakeinfo runtime

* remove call from coinbase. already in block_step

* add negation for pow-reg-allowed

* only root can set min pow diff

* oops

* dont let ck-in-swap-sched move any stake/register

* add tests for validation filter

* add transfer stake to call nontransfer proxy filter

* also add proxy filters for new calls

* update staking priority

* bump spec

* use get_priority_staking for all stake operations

* bump spec

* clippy

* Remove ownership check from transition stake validation

* max the price for EMA calc at 1.0

* uncommitted lockfile change

* bump spec version

* fix merge conflicts

* add CI action that requires clean merges between all named branches

* fix

* fixes

* try again

* fix again

* fix

* fix

* stop needless wasting of CI hours with on push triggers we don't need

* provide an identity for github action to prevent failure

* Add serve_axon extrinsic validation

* Bump spec version

* Check IP validity in serve_axon validation first

* make set diff only root

* add test for set diff no owner

* add migration for min diff

* bump spec

* only allow top-stake SN owner hk to stay immune

* add tests

* only allow replace non-top-stake owner hk

* bump spec

* add tests using SubnetOwnerHotkey

* add impl for replace neuron

* add swap test

* add neuron prune impl

* add swap hotkey impl

* clippy

* clippy

* mistake in test

---------

Co-authored-by: open-junius <[email protected]>
Co-authored-by: Aliaksandr Tsurko <[email protected]>
Co-authored-by: Greg Zaitsev <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: JohnReedV <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: unconst <[email protected]>
Co-authored-by: Unconst <[email protected]>
Co-authored-by: camfairchild <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
garrett-opentensor pushed a commit that referenced this pull request Feb 17, 2025
* upgrade openssl

* fix clippy

* address freeze_struct

* rename commit_reveal_period

* apply criticial openssl update to fix RUSTSEC-2025-0004 (openssl)

* remove subnet_info_v3

* address lint

* update register_network with identity precompile

* fix merge commit

* bump spec

* remove SubnetInfov3 struct

* rename emission_values => emission_value

* bump spec

* safe math

* remove duplicated function

* use saturating math

* add cleaned coinbase

* noclaim

* remove complexity

* non scaled tao emission

* bump

* fix test

* clean coinbase

* pre merge

* no tao in for non registration

* move to moving prices rather than tao reserves

* price

* moving alpha

* bump spec

* Fix tests

* add moving price tests

* add alpha in tests

* Fix all tests

* Format

* Fix unsafe math

* alpha tests

* set tao weight

* reset default staking fee

* fix names

* add mainnet names

* cargo clippy

* cargo fmt

* add a global min burn and migration

* add more tests for root pending etc

* alpha divs

* fix test for root

* new test root tao

* fix wrong parse function

* fix test

* add toggle off for transfers

* delete unused workflow file

* Fix validation for transfer toggle

* remove duplicate tests

* fix subnet creation logic

* cargo fmt

* add new test

* bump spec version to 228

* Add test test_drain_alpha_childkey_parentkey

* spec bump

* fix audit

* fix audit

* fix contract

* commit Cargo.lock

* cargo clippy

* cargo fmt

* fix min lock

* fmt

* fix migration test

* cargo fmt

* fix root

* cargo fmt

* add moving price to metagraph

* use correct min burn init (#1265)

* use correct min brun init

* fmt

* no into

* no into 2

* bump spec

* cargo update to fix cargo audit vulnerabilities

* bump spec version

* moving price init from emission

* cargo fmt

* bump spec version

* commit Cargo.lock

* cargo clippy

* cargo fmt

* DefaultMinimumPoolLiquidity and tempos in rao migration

* update readme of support of M series macs

* bump runtime version

* add tao_emission to stakeinfo runtime

* remove call from coinbase. already in block_step

* add negation for pow-reg-allowed

* only root can set min pow diff

* oops

* dont let ck-in-swap-sched move any stake/register

* add tests for validation filter

* add transfer stake to call nontransfer proxy filter

* also add proxy filters for new calls

* update staking priority

* bump spec

* use get_priority_staking for all stake operations

* bump spec

* clippy

* Remove ownership check from transition stake validation

* max the price for EMA calc at 1.0

* uncommitted lockfile change

* bump spec version

* fix merge conflicts

* add CI action that requires clean merges between all named branches

* fix

* fixes

* try again

* fix again

* fix

* fix

* stop needless wasting of CI hours with on push triggers we don't need

* provide an identity for github action to prevent failure

* Add serve_axon extrinsic validation

* Bump spec version

* Check IP validity in serve_axon validation first

* make set diff only root

* add test for set diff no owner

* add migration for min diff

* bump spec

* only allow top-stake SN owner hk to stay immune

* add tests

* only allow replace non-top-stake owner hk

* bump spec

* add tests using SubnetOwnerHotkey

* add impl for replace neuron

* add swap test

* add neuron prune impl

* add swap hotkey impl

* clippy

* clippy

* mistake in test

* add some tests

* add stake ext test

* add move_stake tests

* cargo lock

* bump spec

* clpy

* use bool return type

* clpy

* add higher liquidity on mvoe stake tests

---------

Co-authored-by: open-junius <[email protected]>
Co-authored-by: Aliaksandr Tsurko <[email protected]>
Co-authored-by: JohnReedV <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: unconst <[email protected]>
Co-authored-by: Greg Zaitsev <[email protected]>
Co-authored-by: Unconst <[email protected]>
Co-authored-by: camfairchild <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
garrett-opentensor pushed a commit that referenced this pull request Feb 24, 2025
* fix migration test

* cargo fmt

* fix root

* cargo fmt

* add moving price to metagraph

* use correct min burn init (#1265)

* use correct min brun init

* fmt

* no into

* no into 2

* bump spec

* cargo update to fix cargo audit vulnerabilities

* bump spec version

* moving price init from emission

* cargo fmt

* bump spec version

* commit Cargo.lock

* cargo clippy

* cargo fmt

* DefaultMinimumPoolLiquidity and tempos in rao migration

* update readme of support of M series macs

* bump runtime version

* add tao_emission to stakeinfo runtime

* Refactor staking and neuron precompile with precompile-utils

* remove call from coinbase. already in block_step

* add negation for pow-reg-allowed

* only root can set min pow diff

* oops

* dont let ck-in-swap-sched move any stake/register

* add tests for validation filter

* add transfer stake to call nontransfer proxy filter

* also add proxy filters for new calls

* update staking priority

* bump spec

* use get_priority_staking for all stake operations

* bump spec

* clippy

* Remove ownership check from transition stake validation

* Fix number conversion issues in staking precompile

* max the price for EMA calc at 1.0

* uncommitted lockfile change

* bump spec version

* fix merge conflicts

* add CI action that requires clean merges between all named branches

* Refactor neuron precompil
- introduce PrecompileHandle and Precompile trait extensions

* fix

* fixes

* try again

* fix again

* fix

* fix

* stop needless wasting of CI hours with on push triggers we don't need

* Refactor metagraph precompile

* fix try runtime endpoints

* fix

* provide an identity for github action to prevent failure

* bump CI

* only run non-devnet try runtime if we are targeting devnet/testnet/main

* tweak

* Add serve_axon extrinsic validation

* Bump spec version

* Check IP validity in serve_axon validation first

* make set diff only root

* add test for set diff no owner

* add migration for min diff

* bump spec

* only allow top-stake SN owner hk to stay immune

* add tests

* only allow replace non-top-stake owner hk

* bump spec

* add tests using SubnetOwnerHotkey

* add impl for replace neuron

* add swap test

* add neuron prune impl

* add swap hotkey impl

* clippy

* clippy

* mistake in test

* add some tests

* add stake ext test

* add move_stake tests

* cargo lock

* bump spec

* clpy

* use bool return type

* clpy

* add higher liquidity on mvoe stake tests

* Refactor subnet precompile

* Reformat

* Update spec version

* Fix commit_hash type in Neuron::commit_weights precompile

* Prevent precision errors in share pool

* Fix unstaking 99.999% and add tests

* Fix event and logging in unstake_from_subnet

* only update tx rate limit *after* ensure

* add test and sn-owner-chk impl

* Fix build

* use is ok and

* Bump spec version

* Update primitives/share-pool/src/lib.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* Update pallets/subtensor/src/tests/staking.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* Remove unused variable

* Add test_get_shares_per_update

* try it again

* use latest rust-cache version

* improve spec version check cache performance

* try busting cache

* it worked 🔥

* use better rust cache throughout CI + clean up CI

* install rust nightly for cargo fmt

* whoops

* fix

* try re-enabling finney try truntime

* Update pallets/subtensor/src/tests/staking.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* fix

* add get value using current_shares arg

* make delegate info useful again

* return different format for get delegated

* remove CODEOWNERS file so we can do green merges

* bump CI

* Set initial tempo to 360

* set equal in mock

* add test for weights rate limit v tempo

* make fields pub for testing

* sub out root divs to get alpha divs

* bump spec version to 241

* const fixes

* cargo clippy

* Add dest hotkey check and test

* Remove the commented test

* Bump spec version

* use rust 1.85.0

* upgrade to Rust 2024 Edition 🎉

* whitelist clippy useless conversion warning

* cargo fmt

* passes clippy

* Remove in/out peers args from docker compose

* fix test

* Update chainspecs

* Remove Stake map - in progress (tests broken)

* become delegate on every add_stake op

* bump spec

* Fix tests

* Fix clippy

* add root set sn moving alpha

* fmt

* fix test

* fixes GH #1330

* bump spec

* add a rate limit-set on decrease take (avoids close increase)

* add test

* add call to associate hk

* update comment from PR1335

* bump spec version

---------

Co-authored-by: unconst <[email protected]>
Co-authored-by: Unconst <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: Greg Zaitsev <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: open-junius <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: Aliaksandr Tsurko <[email protected]>
Co-authored-by: John Reed <[email protected]>
Co-authored-by: camfairchild <[email protected]>
Co-authored-by: gztensor <[email protected]>
Co-authored-by: camfairchild <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants