Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent chain bloat on hotkey swap #1361

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Conversation

bdmason
Copy link

@bdmason bdmason commented Mar 5, 2025

Description

Only creates TotalHotkeyAlpha and TotalHotkeyShares records if they existed pre-swap.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thanks for the PR

@sam0x17
Copy link
Contributor

sam0x17 commented Mar 6, 2025

hey if you could merge main and/or devnet-ready into your branch to fix the merge conflict that would be great!

@bdmason
Copy link
Author

bdmason commented Mar 9, 2025

hey if you could merge main and/or devnet-ready into your branch to fix the merge conflict that would be great!

I've merged devnet-ready, looks good

@sam0x17 sam0x17 merged commit c577a4c into opentensor:devnet-ready Mar 10, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants