Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types e2e test for evm #1374

Merged
merged 8 commits into from
Mar 11, 2025
Merged

add types e2e test for evm #1374

merged 8 commits into from
Mar 11, 2025

Conversation

open-junius
Copy link
Contributor

Description

The PR add e2e test cases for EVM in subtensor. All are implemented in type script.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this Mar 7, 2025
Copy link
Contributor

@ales-otf ales-otf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we can have it in the main repo! And having it type-safe is an additional benefit. I noticed a few code quality issues though. Additionally to them there are a lot of commented code. But feel free to ignore my comments.

@open-junius open-junius requested a review from ales-otf March 10, 2025 16:07
Copy link
Contributor

@ales-otf ales-otf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Junius! i've noticed just a few more issues in readme. but they are minor, you can ignore them if you wish.


## update dependence for coding

npm update @polkadot-api/descriptors
```bash
yarn upgrade @polkadot-api/descriptors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this last time and confused now. as far as i understand it, this command does the same as cargo update in rust - it updates dependencies versions in the manifest. i suppose we wouldn't like it to be happened every time the repo is cloned. otherwise why this command is listed here particularly for this dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found out if we generate a new metadata in .papi which including the new extrinsic, for instance. But the IDE doesn't show the new one. I need run it to refresh. It is little confused. I will remove it and put it in personal notes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, if it's needed to generate metadata, then it's better to keep it, but mentioned it in here.

@open-junius open-junius added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Mar 11, 2025
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Mar 11, 2025
@open-junius open-junius requested a review from ales-otf March 11, 2025 15:36
@sam0x17 sam0x17 merged commit c771436 into devnet-ready Mar 11, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants