call validate
in pre_dispatch
to have same validations
#1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the runtime which can allow malicious block author to include invalid txs in a block. It fixes the issue by doing the same checks as
validate
inpre_dispatch
method ofSubtensorSignedExtension
.The inclusion of same checks in
pre_dispatch
mean that the checks are being run duringExecutive::apply_extrinsic
when the block is being executed against the current state.Related Issue(s)
Type of Change
Breaking Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Additional Notes