[posix] Add posix Cli Daemon module: unit test update

openthread · Feb 20, 2025 · b9057c5 · b9057c5
1 parent bffbb89
commit b9057c5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/src/host/posix/cli_daemon.hpp b/src/host/posix/cli_daemon.hpp
@@ -44,15 +44,15 @@ namespace otbr {
 class CliDaemon
 {
 public:
-    CliDaemon();
+    CliDaemon(void);
 
     void Init(const std::string &aNetIfName);
 
-    std::string GetSocketFilename(const char *aSuffix) const;
-
 private:
     void CreateListenSocketOrDie(void);
 
+    std::string GetSocketFilename(const char *aSuffix) const;
+
     int mListenSocket;
     int mDaemonLock;
 

diff --git a/tests/gtest/test_cli_daemon.cpp b/tests/gtest/test_cli_daemon.cpp
@@ -53,30 +53,31 @@
 
 TEST(CliDaemon, InitSocketCreationWithFullNetIfName)
 {
-    const char *netif_name = "tun0";
+    const char *netIfName  = "tun0";
+    const char *socketFile = "openthread-tun0.sock";
+    const char *lockFile   = "openthread-tun0.lock";
 
     otbr::CliDaemon cliDaemon;
-    cliDaemon.Init(netif_name);
+    cliDaemon.Init(netIfName);
 
     struct stat st;
-    std::string socketFile = cliDaemon.GetSocketFilename(".sock");
-    std::string lockFile   = cliDaemon.GetSocketFilename(".lock");
 
-    EXPECT_EQ(stat(socketFile.c_str(), &st), 0);
-    EXPECT_EQ(stat(lockFile.c_str(), &st), 0);
+    EXPECT_EQ(stat(socketFile, &st), 0);
+    EXPECT_EQ(stat(lockFile, &st), 0);
 }
 
 TEST(CliDaemon, InitSocketCreationWithEmptyNetIfName)
 {
+    const char *socketFile = "openthread-wpan0.sock";
+    const char *lockFile   = "openthread-wpan0.lock";
+
     otbr::CliDaemon cliDaemon;
     cliDaemon.Init("");
 
     struct stat st;
-    std::string socketFile = cliDaemon.GetSocketFilename(".sock");
-    std::string lockFile   = cliDaemon.GetSocketFilename(".lock");
 
-    EXPECT_EQ(stat(socketFile.c_str(), &st), 0);
-    EXPECT_EQ(stat(lockFile.c_str(), &st), 0);
+    EXPECT_EQ(stat(socketFile, &st), 0);
+    EXPECT_EQ(stat(lockFile, &st), 0);
 }
 
 #endif // __linux__