[pd] add pd daemon service to support the automation of dhcpcd PD management #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
- Coverage 55.77% 45.95% -9.83%
==========================================
Files 87 105 +18
Lines 6890 12575 +5685
Branches 0 912 +912
==========================================
+ Hits 3843 5779 +1936
- Misses 3047 6482 +3435
- Partials 0 314 +314 ☔ View full report in Codecov by Sentry. |
sherysheng
requested review from
erjiaqing,
alinlazar,
Irving-cl and
superwhd
and removed request for
alinlazar
Irving-cl
reviewed
Jul 5, 2024
Irving-cl
reviewed
Jul 5, 2024
superwhd
reviewed
Jul 5, 2024
erjiaqing
reviewed
Jul 8, 2024
23 tasks
|
@jwhui @sherysheng Can we prioritize getting this change in soon? It appears we're waiting on this for some PD client qualifying tests in certification. |
superwhd
reviewed
Oct 15, 2024
erjiaqing
reviewed
Oct 15, 2024
superwhd
reviewed
Oct 31, 2024
| backup_dir = "/var/lib/ot-dhcpcd-backup" | ||
|
|
||
| def properties_changed_handler(interface_name, changed_properties, invalidated_properties): | ||
| if "Dhcp6PdState" in changed_properties: |
There was a problem hiding this comment.
You may replace is large 'if' block with an early return.
yangsong-cnyn
force-pushed
the
pd_daemon
branch
from
8653134
to
5282dfa
Compare
erjiaqing
reviewed
Oct 31, 2024
| if os.path.isfile("/etc/dhcpcd.conf.custom"): | ||
| subprocess.run(["sudo", "cp", "/etc/dhcpcd.conf.custom", "/etc/dhcpcd.conf"], check=True) | ||
| try: | ||
| subprocess.run(["sudo", "systemctl", "daemon-reload"], check=True) |
There was a problem hiding this comment.
I think this daemon-reload is not necessary?
yangsong-cnyn
force-pushed
the
pd_daemon
branch
from
5282dfa
to
dfa3c73
Compare
|
Local test result 10/31:
|
superwhd
reviewed
Nov 1, 2024
yangsong-cnyn
force-pushed
the
pd_daemon
branch
2 times, most recently
from
b769abc
to
9dcb5f5
Compare
yangsong-cnyn
force-pushed
the
pd_daemon
branch
from
9dcb5f5
to
558ca76
Compare
superwhd
reviewed
Nov 5, 2024
yangsong-cnyn
force-pushed
the
pd_daemon
branch
from
cf64ec4
to
72bef12
Compare
erjiaqing
reviewed
Nov 5, 2024
superwhd
reviewed
Nov 5, 2024
| backup_dir = "/var/lib/ot-dhcpcd-backup" | ||
|
|
||
| def properties_changed_handler(interface_name, changed_properties, invalidated_properties): | ||
| if "Dhcp6PdState" in changed_properties: |
yangsong-cnyn
force-pushed
the
pd_daemon
branch
2 times, most recently
from
3e14b61
to
a3033df
Compare
yangsong-cnyn
force-pushed
the
pd_daemon
branch
from
a3033df
to
1edc4f1
Compare
yangsong-cnyn
approved these changes
Nov 5, 2024
erjiaqing
reviewed
Nov 6, 2024
erjiaqing
approved these changes
Nov 7, 2024
jwhui
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes include:
PD daemon (dhcp6_pd_daemon.py) to monitor and react to PD state changes between running and stopped/disabled.
Creation of systemd service file (dhcp6_pd_daemon.service) for managing the daemon.
Update of _dhcpv6_pd_ref to support pd daemon installation and uninstallation
This scripts essentially automate the process of setting up a machine as a dhcpcd pd reference device, handling prefix delegation.
local test log:
Terminal #1:
sherys@raspberrypi:~ $ python3 dhcp6_pd_daemon.py
2024-07-06 03:35:31,718 - INFO - Connected to D-Bus signal.
2024-07-06 03:35:41,577 - INFO - Dhcp6PdState changed to: running
2024-07-06 03:35:42,182 - INFO - Successfully restarted dhcpcd service.
Terminal #2:
Terminal #3:
signal time=1719724170.782791 sender=:1.32 -> destination=(null destination) serial=14 path=/io/openthread/BorderRouter/wpan0; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
string "io.openthread.BorderRouter"
array [
dict entry(
string "Dhcp6PdState"
variant string "running"
)
]
array [
]
signal time=1719724369.495711 sender=:1.32 -> destination=(null destination) serial=16 path=/io/openthread/BorderRouter/wpan0; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
string "io.openthread.BorderRouter"
array [
dict entry(
string "Dhcp6PdState"
variant string "disabled"
)
]
array [
]