Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[posix] add virtual destructor for InfraIf::Dependencies #2599

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[posix] add virtual destructor for InfraIf::Dependencies #2599

merged 1 commit into from
Nov 14, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR adds virtual destructor for InfraIf::Dependencies.

On some platforms this will cause build warnings and errors.

mia1yang
mia1yang approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@mia1yang mia1yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

superwhd
superwhd approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Irving-cl Irving-cl requested a review from jwhui November 14, 2024 04:55
@jwhui jwhui merged commit 4589255 into openthread:main Nov 14, 2024
32 checks passed
@Irving-cl Irving-cl deleted the missing_virtual_dtor branch November 15, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mia1yang mia1yang mia1yang approved these changes

@jwhui jwhui jwhui approved these changes

@superwhd superwhd superwhd approved these changes

Assignees
No one assigned
Labels
enhancement P2 platform: posix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Irving-cl @superwhd @jwhui @mia1yang