[pd] daemon service: reconnect to dbus on dbus reset #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2605 +/- ##
==========================================
- Coverage 55.77% 45.91% -9.87%
==========================================
Files 87 106 +19
Lines 6890 12624 +5734
Branches 0 915 +915
==========================================
+ Hits 3843 5796 +1953
- Misses 3047 6511 +3464
- Partials 0 317 +317 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
yangsong-cnyn
changed the title
superwhd
reviewed
Nov 18, 2024
yangsong-cnyn
force-pushed
the
pd_daemon
branch
from
7b9e92b
to
3d43baa
Compare
yangsong-cnyn
force-pushed
the
pd_daemon
branch
from
3d43baa
to
88e1433
Compare
yangsong-cnyn
force-pushed
the
pd_daemon
branch
2 times, most recently
from
740fdb5
to
b516ccd
Compare
yangsong-cnyn
changed the title
superwhd
reviewed
Nov 21, 2024
yangsong-cnyn
force-pushed
the
pd_daemon
branch
from
b516ccd
to
4b03dee
Compare
jwhui
changed the title
jwhui
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a potential issue where the pd daemon loses its dbus connection when original dbus is reset. The daemon now monitors the io.openthread.BorderRouter.wpan0 dbus name and reconnects if the name owner changes, indicating a likely otbr-agent reload. This ensures the daemon continues to function correctly after dbus is reset by otbr-agent.