-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[log] add Android log system support #2614
Conversation
4e58a83
to
78d16f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
==========================================
- Coverage 55.77% 45.92% -9.86%
==========================================
Files 87 106 +19
Lines 6890 12624 +5734
Branches 0 915 +915
==========================================
+ Hits 3843 5797 +1954
- Misses 3047 6511 +3464
- Partials 0 316 +316 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Will |
The final minimum output log level is determined by the highest value of OT log level and Android log level. For example, if the Android log level is set to |
Developers can use the command `ot-ctl log level 5` to change the default log level to DEBUG. Sometimes, the `ot-daemon` crashes before developers can run the ot-ctl command on Android. This commit add Android log system support, so that developers can run the command `setprop log.tag.ot-daemon DEBUG` to change the log level before the ot-daemon runs.
78d16f6
to
e4765e5
Compare
Developers can use the command
ot-ctl log level 5
to change the default log level to DEBUG. Sometimes, theot-daemon
crashes before developers can run the ot-ctl command on Android.This commit adds the Android log system support, so that developers can run the command
setprop log.tag.ot-daemon DEBUG
to change the log level before the ot-daemon runs. The log output format is the same with using the Linux log system.