feat: features OTCR natively in canary

src/creatures/players/player.cpp

@@ -9613,6 +9613,12 @@ void Player::sendMapShader(const std::string &shaderName) const {
 	}
 }
 
+void Player::sendPlayerTyping(const std::shared_ptr<Creature> &creature, uint8_t typing) const {
+	if (client) {
+		client->sendPlayerTyping(creature, typing);
+	}
+}
+
 void Player::sendSingleSoundEffect(const Position &pos, SoundEffect_t id, SourceEffect_t source) const {
 	if (client) {
 		client->sendSingleSoundEffect(pos, id, source);

src/creatures/players/player.hpp

@@ -1272,6 +1272,7 @@ class Player final : public Creature, public Cylinder, public Bankable {
 	void setMapShader(const std::string &shaderName) {
 		this->mapShader = shaderName;
 	}
+	void sendPlayerTyping(const std::shared_ptr<Creature> &creature, uint8_t typing) const;
 
 private:
 	friend class PlayerLock;

src/game/game.cpp

@@ -10857,7 +10857,7 @@ void Game::sendAttachedEffect(const std::shared_ptr<Creature> &creature, uint16_
 	auto spectators = Spectators().find<Creature>(creature->getPosition(), true);
 	for (const auto &spectator : spectators) {
 		auto player = spectator->getPlayer();
-		if (player) { // Solo procede si player no es nullptr
+		if (player) {
 			player->sendAttachedEffect(creature, effectId);
 		}
 	}
@@ -10866,7 +10866,7 @@ void Game::sendDetachEffect(const std::shared_ptr<Creature> &creature, uint16_t
 	auto spectators = Spectators().find<Creature>(creature->getPosition(), true);
 	for (const auto &spectator : spectators) {
 		auto player = spectator->getPlayer();
-		if (player) { // Solo procede si player no es nullptr
+		if (player) { 
 			player->sendDetachEffect(creature, effectId);
 		}
 	}
@@ -10875,8 +10875,24 @@ void Game::updateCreatureShader(const std::shared_ptr<Creature> &creature) {
 	auto spectators = Spectators().find<Creature>(creature->getPosition(), true);
 	for (const auto &spectator : spectators) {
 		auto player = spectator->getPlayer();
-		if (player) { // Solo procede si player no es nullptr
+		if (player) {
 			player->sendShader(creature, creature->getShader());
 		}
 	}
 }
+
+void Game::playerSetTyping(uint32_t playerId, uint8_t typing) {
+	const auto &player = getPlayerByID(playerId);
+	if (!player) {
+		return;
+	}
+	auto spectators = Spectators().find<Creature>(player->getPosition(), true);
+	auto playersSpectators = spectators.filter<Player>();
+	for (const auto &spectator : spectators) {
+		if (const auto &tmpPlayer = spectator->getPlayer()) {
+			tmpPlayer->sendPlayerTyping(player, typing);
+		}
+	}
+}
+
+

src/game/game.hpp

@@ -715,6 +715,8 @@ class Game {
 	void sendAttachedEffect(const std::shared_ptr<Creature> &creature, uint16_t effectId);
 	void sendDetachEffect(const std::shared_ptr<Creature> &creature, uint16_t effectId);
 	void updateCreatureShader(const std::shared_ptr<Creature> &creature);
+	void playerSetTyping(uint32_t playerId, uint8_t typing);
+
 
 private:
 	std::map<uint16_t, Achievement> m_achievements;

src/server/network/protocol/protocolgame.cpp

@@ -1032,6 +1032,9 @@ void ProtocolGame::parsePacketFromDispatcher(NetworkMessage &msg, uint8_t recvby
 		case 0x32:
 			parseExtendedOpcode(msg);
 			break; // otclient extended opcode
+		case 0x38:
+			parsePlayerTyping(msg); // player are typing or not
+			break; 
 		case 0x60:
 			parseInventoryImbuements(msg);
 			break;
@@ -2512,6 +2515,11 @@ void ProtocolGame::parseCyclopediaMonsterTracker(NetworkMessage &msg) {
 	}
 }
 
+void ProtocolGame::parsePlayerTyping(NetworkMessage &msg) {
+	uint8_t typing = msg.getByte();
+	g_dispatcher().addEvent([self = getThis(), playerID = player->getID(), typing] { g_game().playerSetTyping(playerID, typing); }, __FUNCTION__);
+}
+
 void ProtocolGame::sendTeamFinderList() {
 	if (!player || oldProtocol) {
 		return;
@@ -9319,3 +9327,14 @@ void ProtocolGame::sendMapShader(const std::string &shaderName) {
 	msg.addString(shaderName);
 	writeToOutputBuffer(msg);
 }
+
+void ProtocolGame::sendPlayerTyping(const std::shared_ptr<Creature> &creature, uint8_t typing) {
+	if (!isOTC || player->getOperatingSystem() >= CLIENTOS_OTCLIENTV8_LINUX) {
+		return;
+	}
+	NetworkMessage msg;
+	msg.addByte(0x38);
+	msg.add<uint32_t>(creature->getID());
+	msg.addByte(typing);
+	writeToOutputBuffer(msg);
+}

src/server/network/protocol/protocolgame.hpp

@@ -489,6 +489,13 @@ class ProtocolGame final : public Protocol {
 
 	// OTCv8
 	void sendFeatures();
+	// OTCR
+	void sendAttachedEffect(const std::shared_ptr<Creature> &creature, uint16_t effectId);
+	void sendDetachEffect(const std::shared_ptr<Creature> &creature, uint16_t effectId);
+	void sendShader(const std::shared_ptr<Creature> &creature, const std::string &shaderName);
+	void sendMapShader(const std::string &shaderName);
+	void sendPlayerTyping(const std::shared_ptr<Creature> &creature, uint8_t typing);
+	void parsePlayerTyping(NetworkMessage &msg);
 
 	void parseInventoryImbuements(NetworkMessage &msg);
 	void sendInventoryImbuements(const std::map<Slots_t, std::shared_ptr<Item>> &items);
@@ -542,10 +549,6 @@ class ProtocolGame final : public Protocol {
 	void sendHotkeyPreset();
 	void sendTakeScreenshot(Screenshot_t screenshotType);
 	void sendDisableLoginMusic();
-	void sendAttachedEffect(const std::shared_ptr<Creature> &creature, uint16_t effectId);
-	void sendDetachEffect(const std::shared_ptr<Creature> &creature, uint16_t effectId);
-	void sendShader(const std::shared_ptr<Creature> &creature, const std::string &shaderName);
-	void sendMapShader( const std::string &shaderName);
 
 	uint8_t m_playerDeathTime = 0;