Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spells and runes interactions #3241

Closed
wants to merge 21 commits into from
Closed

fix: spells and runes interactions #3241

wants to merge 21 commits into from

Conversation

kaleohanopahala
Copy link
Contributor

@kaleohanopahala kaleohanopahala commented Jan 10, 2025 •
edited
Loading

  • It is now possible to throw runes over stairs and holes (Global Condition), and use spells on walls.
  • An efficiency improvement was also made to avoid unnecessary reallocations.
  • Correct actions like a global tibia.

image
image
image
image

Maybe can close issue #2446

phacUFPE
phacUFPE approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working as expected.

jprzimba added a commit to jprzimba/crystalserver that referenced this pull request Jan 11, 2025
@jprzimba
* Fix spells and runes interactions
05d55db 
opentibiabr/canary#3241

Ty @kaleohanopahala
@majestyotbr majestyotbr marked this pull request as draft January 20, 2025 19:00
@kaleohanopahala kaleohanopahala marked this pull request as ready for review January 23, 2025 22:38
@XmasGame
Copy link

XmasGame commented Jan 24, 2025 •
edited
Loading

Video.sin.titulo.Hecho.con.Clipchamp.mp4

Sin título
Sin título2

bug on stairs

@kaleohanopahala
Copy link
Contributor Author

@XmasGame can you test again? ☻

@XmasGame
Copy link

@XmasGame can you test again? ☻

Have you changed something?
I have not ethernet hehe

@XmasGame
Copy link

XmasGame commented Jan 25, 2025 •
edited
Loading

@XmasGame can you test again? ☻

Have you changed something? I have not ethernet hehe

Edit:
-magic wall and wild growth rune works correctly ✅

  • field items runes (like fire bomb, poison wall energy field, etc) ‼️
    image
    image

grettings!

@murilo09 murilo09 marked this pull request as draft January 25, 2025 16:24
@kaleohanopahala
Copy link
Contributor Author

kaleohanopahala commented Jan 25, 2025 •
edited
Loading

there's no problem here, you tested the updated files?
You need to update your source files too.

image
image

@XmasGame
Copy link

image
image

I apologize... was my fault, I forget a few lines...

Works perfectly! thanks!

@kaleohanopahala kaleohanopahala marked this pull request as ready for review January 26, 2025 17:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@murilo09
Copy link
Contributor

murilo09 commented Feb 4, 2025 •
edited
Loading

It's not yet possible to throw an avalanche at a magic wall (ID 2128 and 10181).
https://youtu.be/Q5ItUPYRZv4?t=510

This was linked to issues Feb 4, 2025
Runes usage in tiles. #2446
Open
You cannot use a frontal attack spell on a magic wall. #2794
Open
@kaleohanopahala kaleohanopahala deleted the spells branch February 6, 2025 02:56
@kaleohanopahala kaleohanopahala restored the spells branch February 6, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majestyotbr majestyotbr Awaiting requested review from majestyotbr

@phacUFPE phacUFPE Awaiting requested review from phacUFPE

@dudantas dudantas Awaiting requested review from dudantas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You cannot use a frontal attack spell on a magic wall. Runes usage in tiles.
6 participants
@kaleohanopahala @XmasGame @murilo09 @dudantas @phacUFPE @majestyotbr