fix: house transfer item to owner #3258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the house item transfer system during server startup. Specifically, the
getPlayerByGUID
function was not passingtrue
to retrieve offline players, which caused items belonging to offline players to be removed instead of being correctly transferred to their inbox. Additionally, the logic for handling ownership of items was improved to ensure the correct transfer of items to their respective owners, even when no players are online during server startup.Behaviour
Actual
When transferring house items during server startup:
getPlayerByGUID
function does not retrieve offline players because thetrue
parameter is not passed.Expected
When transferring house items during server startup:
getPlayerByGUID
function retrieves offline players by passing thetrue
parameter.Type of change
Please delete options that are not relevant.
How Has This Been Tested
The following tests were performed to verify the fix:
Checklist