fix: remove player from party on death

[bdzicc]

Description

When a player dies they are not being removed from their party.
This causes an issue if the party leader dies the leadership is not passed to another member and the party must be disbanded and recreated to form another leader.
Also, two player parties will not be disbanded if one of the players dies.

Behaviour

Actual

Player dies and does not get removed from party.
Two player parties do not get disbanded if a party member dies.
Party leader dies in a party of three or more players and leadership does not get passed to a new member.

Expected

Player dies and gets removed from party.
Two player parties get disbanded if a party member dies.
Party leader dies in a party of three or more players and leadership gets passed to a new member.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• Tested dying while in a party and ensured player left upon death
• Tested dying while in a two player party and ensured it got disbanded.
• Tested dying while leader of a party of three players and ensured leadership was passed.

Test Configuration:

• Server Version: Main
• Client: Mehah OTC Redemption
• Operating System: Windows 10

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[murilo09]

the player not being removed is normal behavior, create a flag on config.lua

[dudantas]

The player should not be removed from the party upon death, it is expected behavior so will be removed if they click "cancel" on the death screen.

[bdzicc]

Thanks for the info. I have added a config flag for this as requested.

If I may ask, what is the point of the player remaining in the party after death? Should they still be a party member if they click "OK" on the death screen and log back in?

Also, are you saying clicking "Cancel" on the death screen should remove the player from the party because that does not work for me. The client does send a packet for logout() but it gets caught in parsePacketDead() method and not handled by the dispatcher.

[murilo09]

Add to the config.lua.dist as well

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud