Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline usage, installation and configuration of ots-git-gpg-wrapper.sh #121

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Sep 28, 2021

  1. Make ots-git-gpg-wrapper.sh configurable

    - via `git config opentimestamps.enable` option
    - via environment variables OPENTIMESTAMPS*
    nobodyinperson committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    741b0b1 View commit details
    Browse the repository at this point in the history
  2. Let ots-git-gpg-wrapper find gpg, not the wrapper

    This is more straight-forward than to hard-code /usr/bin/gpg in
    ots-git-gpg-wrapper and then using `which` in the ots-git-gpg-wrapper.sh
    to find gpg.
    nobodyinperson committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    50d4858 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    116221f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ff6ef6e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Configuration menu
    Copy the full SHA
    31c1bde View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. 🩹 Fix creation of invalid PGP signatures with git options

    Options directly passed to git (like `git -c config.bla` or
    `git --git-dir=...`) caused the first argument to show up before the PGP
    signature, breaking git {log,show} --show-signature and thus also OTS
    verification. This was especially annyoing as `git annex sync` or
    `datalad save` pass options like this to git when committing.
    
    With quite some `strace`ing and debugging I was finally
    able to track down this bug to this missing `-q` to that one grep in the
    OTS shell wrapper 🤦
    
    It might be a good idea to ditch the shell wrapper and use a proper
    Python for this. Wouldn't have happened with Python...
    nobodyinperson committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    9d34cb1 View commit details
    Browse the repository at this point in the history