fix: import dependency with function #229
Conversation
WalkthroughThe changes update the Changes
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/fluent-editor/src/modules/custom-image/image-bar.ts (1)
1-1: LGTM! The import change resolves the version compatibility issue.Using
Quill.import('delta')is the correct approach as it leverages Quill's runtime module system, making it more resilient to version changes.Consider adding error handling for the import:
-const Delta = Quill.import('delta') +const Delta = Quill.import('delta') || null +if (!Delta) { + throw new Error('Delta module not found in Quill') +}Also applies to: 5-5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/fluent-editor/src/modules/custom-image/image-bar.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
export
Deltais only supported from version 2.0.3. but in the dependencies of package.json, quill is 2.0.0. if not install the 2.0.3 version quill will have an error like this:Error node_modules/@opentiny/fluent-editor/es/modules/custom-image/image-bar.es.js:1:16: 1 │ import Quill, { Delta } from "quill"; ╵ ~~~~~ Error: Build failed with 1 error: node_modules/@opentiny/fluent-editor/es/modules/custom-image/image-bar.es.js:1:16: ERROR: No matching export in "node_modules/quill/quill.js" for import "Delta" at failureErrorWithLog (/home/projects/vitejs-vite-5v69mt/node_modules/esbuild/lib/main.js:1462:15) at eval (/home/projects/vitejs-vite-5v69mt/node_modules/esbuild/lib/main.js:935:25) at eval (/home/projects/vitejs-vite-5v69mt/node_modules/esbuild/lib/main.js:1343:9) { errors: [Getter/Setter], warnings: [Getter/Setter] }Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
These improvements are internal and do not affect visible functionality.