Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: table-up support #232

Merged
merged 2 commits into from
Feb 25, 2025
Merged

feat: table-up support #232

merged 2 commits into from
Feb 25, 2025

Conversation

zzxming
Copy link
Member

@zzxming zzxming commented Feb 22, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added enhancement New feature or request v4 labels Feb 22, 2025
Copy link

coderabbitai bot commented Feb 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kagol
Copy link
Member

kagol commented Feb 25, 2025

@zzxming 我试了下,table-up 体验更好一些,可以在 v4 移除 better-table 了

@kagol kagol merged commit a4be786 into opentiny:v4 Feb 25, 2025
1 check passed
@kagol
Copy link
Member

kagol commented Feb 25, 2025

@zzxming 这个勾选框样式有点问题
image

@zzxming
Copy link
Member Author

zzxming commented Feb 25, 2025

这个勾选框样式有点问题

在 vitepress 的样式下打勾会有问题,这里我把打勾去掉了。我之后会把这个样式改掉,打勾的方式在不同分辨率上,有视觉不居中的情况,后续我更新模块,再处理这个

@kagol
Copy link
Member

kagol commented Feb 25, 2025

@zzxming 还有个问题,现在执行:pnpm build,构建网站失败,报以下错误:

✖ rendering pages...
build error:
document is not defined
ReferenceError: document is not defined

查看报错信息:https://github.com/opentiny/tiny-editor/actions/runs/13522257057

应该是跟 table-up.md 中引入的三个 xx.vue 文件有关。

去掉 table-up.md 文件中的以下代码就不报错了:

image

@zzxming zzxming deleted the feat-table branch February 26, 2025 02:17
@zzxming
Copy link
Member Author

zzxming commented Feb 26, 2025

执行:pnpm build,构建网站失败,报以下错误:

✖ rendering pages...
build error:
document is not defined
ReferenceError: document is not defined

ssr 的问题先做个简单处理吧,这个估计要改的比较多,模块下个版本发布的时候我再改回来

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants