Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not run wrangler command in directories #300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

diofeher
Copy link
Member

Wrangler. does not support r2 object put for directories. While we run the script, directories are listed too and we try to upload them to the bucket, receiving errors.

To decrease the error output for this command, we are not trying to add directories anymore.

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • My contribution is compatible with the MPL-2.0 license and I have provided a DCO sign-off on all my commits.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.

@diofeher diofeher requested a review from a team February 25, 2025 19:59
fs.lstat(realFilePath, (err, stats) => {

if(err)
return console.log(err); //Handle error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this return undefined?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's just for returning the callback at that point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants