Skip to content

Commit

Permalink
Add computed to node_config.kubelet_config & node_pool_auto_config.no…
Browse files Browse the repository at this point in the history
…de_kubelet_config (hashicorp#11971) (hashicorp#19817)

[upstream:6fa720faca94d244d849be547ecffb482e6a3b75]

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored and rileykarson committed Oct 11, 2024
1 parent a8eb48d commit 4ff48be
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .changelog/11971.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
```release-note:bug
container: fixed a diff triggered by a new API-side default value for `node_config.0.kubelet_config.0.insecure_kubelet_readonly_port_enabled`. Terraform will now accept server-specified values for `node_config.0.kubelet_config` when it is not defined in configuration and will not detect drift. Note that this means that removing the value from configuration will now preserve old settings instead of reverting the old settings.
```
```release-note:enhancement
container: `google_container_cluster` will now accept server-specified values for `node_pool_auto_config.0.node_kubelet_config` when it is not defined in configuration and will not detect drift. Note that this means that removing the value from configuration will now preserve old settings instead of reverting the old settings.
```
2 changes: 2 additions & 0 deletions google/services/container/node_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,7 @@ func schemaNodeConfig() *schema.Schema {
"kubelet_config": {
Type: schema.TypeList,
Optional: true,
Computed: true,
MaxItems: 1,
Description: `Node kubelet configs.`,
Elem: &schema.Resource{
Expand Down Expand Up @@ -741,6 +742,7 @@ func schemaNodePoolAutoConfigNodeKubeletConfig() *schema.Schema {
return &schema.Schema{
Type: schema.TypeList,
Optional: true,
Computed: true,
MaxItems: 1,
Description: `Node kubelet configs.`,
Elem: &schema.Resource{
Expand Down

0 comments on commit 4ff48be

Please sign in to comment.