Skip to content

Switch formatted currency number to intl string so we can override #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Switch formatted currency number to intl string so we can override #1384

wants to merge 3 commits into from

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:

This passes the formatted fare to an intl string so that we can override the string in custom configs if necessary

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

miles-grant-ibigroup
miles-grant-ibigroup approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So annoying but glad it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

@daniel-heppner-ibigroup daniel-heppner-ibigroup Awaiting requested review from daniel-heppner-ibigroup

Assignees

@daniel-heppner-ibigroup daniel-heppner-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @miles-grant-ibigroup @daniel-heppner-ibigroup