IApiConnectionインタフェースを再設計 #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upsilon
force-pushed
the
api-connection
branch
from
761a859 to
c3e2600
Compare
upsilon
added a commit
that referenced
this pull request
Dec 15, 2023
#273 による変更のうち HandleTimeout メソッドを追加したことで、API リクエストがタイムアウトした場合に キャンセル処理が完全に終了するのを待たずに Task が完了するようになる。 TimelineScheduler による定期的なタイムライン更新では、非同期タスクの完了を待って から次の更新をスケジュールする挙動のため、更新処理がタイムアウト時間を大幅に 超えても完了しない状態になると次回以降の更新が行われなくなってしまう。 #259 のエラーが起こる原因は 特定できていないが、もし HttpClient のキャンセル処理が原因であればこの変更で 改善される可能性がある。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.