Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimelineTweetに含まれる引用ツイートの取得に対応 #277

Merged
merged 2 commits into from
Dec 11, 2023
Merged

TimelineTweetに含まれる引用ツイートの取得に対応 #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e016aea
OpenTween.Tests/Resources以下にあるファイルのCopyToOutputDirectoryを一括で設定する
upsilon Dec 11, 2023
cda0532
TimelineTweetに含まれる引用ツイートの取得に対応
upsilon Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
更新履歴

==== Unreleased
* NEW: graphqlエンドポイント経由で取得した引用ツイートの表示に対応

==== Ver 3.9.0(2023/12/03)
* NEW: graphqlエンドポイントに対するレートリミットの表示に対応
Expand Down
28 changes: 28 additions & 0 deletions OpenTween.Tests/Api/GraphQL/TimelineTweetTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,34 @@ public void ToStatus_WithTwitterPostFactory_SelfThread_Test()
Assert.Equal(40480664L, post.UserId);
}

[Fact]
public void ToStatus_WithTwitterPostFactory_QuotedTweet_Test()
{
var rootElm = this.LoadResponseDocument("TimelineTweet_QuotedTweet.json");
var timelineTweet = new TimelineTweet(rootElm);
var status = timelineTweet.ToTwitterStatus();
var postFactory = new TwitterPostFactory(this.CreateTabInfo());
var post = postFactory.CreateFromStatus(status, selfUserId: 1L, new HashSet<long>());

Assert.Equal("1588614645866147840", post.StatusId.Id);
var quotedPostId = Assert.Single(post.QuoteStatusIds);
Assert.Equal("1583108196868116480", quotedPostId.Id);
}

[Fact]
public void ToStatus_WithTwitterPostFactory_QuotedTweet_Tombstone_Test()
{
var rootElm = this.LoadResponseDocument("TimelineTweet_QuotedTweet_Tombstone.json");
var timelineTweet = new TimelineTweet(rootElm);
var status = timelineTweet.ToTwitterStatus();
var postFactory = new TwitterPostFactory(this.CreateTabInfo());
var post = postFactory.CreateFromStatus(status, selfUserId: 1L, new HashSet<long>());

Assert.Equal("1614653321310253057", post.StatusId.Id);
var quotedPostId = Assert.Single(post.QuoteStatusIds);
Assert.Equal("1614650279194136576", quotedPostId.Id);
}

[Fact]
public void ToStatus_WithTwitterPostFactory_PromotedTweet_Test()
{
Expand Down
74 changes: 1 addition & 73 deletions OpenTween.Tests/OpenTween.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,79 +44,7 @@
<PackageReference Include="Xunit.StaFact" Version="1.1.11" />
</ItemGroup>
<ItemGroup>
<None Update="Resources\re.gif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\re1.gif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\re1.png">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\CreateRetweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\CreateTweet_CircleTweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\DeleteRetweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\DeleteTweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\Error_NotFound.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\SearchTimeline_SimpleTweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\SearchTimeline_SuccessWithError.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\TimelineTweet_PromotedTweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\TimelineTweet_RetweetedTweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\TimelineTweet_TweetTombstone.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\TimelineTweet_TweetWithVisibility.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\TimelineTweet_TweetWithMedia.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\TimelineTweet_SimpleTweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\ListLatestTweetsTimeline_Conversation.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\ListLatestTweetsTimeline_SimpleTweet.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\TweetDetail.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\TimelineTweet_SelfThread.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\UserByScreenName_Suspended.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\User_EntityWithoutDisplayUrl.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\User_Simple.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\UserByScreenName.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Resources\Responses\UserTweetsAndReplies_SimpleTweet.json">
<None Update="Resources\**\*">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>
Expand Down
252 changes: 252 additions & 0 deletions OpenTween.Tests/Resources/Responses/TimelineTweet_QuotedTweet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,252 @@
{
"itemType": "TimelineTweet",
"__typename": "TimelineTweet",
"tweet_results": {
"result": {
"__typename": "Tweet",
"rest_id": "1588614645866147840",
"has_birdwatch_notes": false,
"core": {
"user_results": {
"result": {
"__typename": "User",
"id": "VXNlcjo0MDQ4MDY2NA==",
"rest_id": "40480664",
"affiliates_highlighted_label": {},
"has_graduated_access": false,
"is_blue_verified": false,
"profile_image_shape": "Circle",
"legacy": {
"can_dm": true,
"can_media_tag": true,
"created_at": "Sat May 16 15:20:01 +0000 2009",
"default_profile": false,
"default_profile_image": false,
"description": "",
"entities": {
"description": {
"urls": []
},
"url": {
"urls": [
{
"display_url": "m.upsilo.net/@upsilon",
"expanded_url": "https://m.upsilo.net/@upsilon",
"url": "https://t.co/vNMmyHHh15",
"indices": [
0,
23
]
}
]
}
},
"fast_followers_count": 0,
"favourites_count": 215369,
"followers_count": 1287,
"friends_count": 1,
"has_custom_timelines": false,
"is_translator": false,
"listed_count": 92,
"location": "Funabashi, Chiba, Japan",
"media_count": 876,
"name": "upsilon",
"needs_phone_verification": false,
"normal_followers_count": 1287,
"pinned_tweet_ids_str": [],
"possibly_sensitive": false,
"profile_banner_url": "https://pbs.twimg.com/profile_banners/40480664/1349188016",
"profile_image_url_https": "https://pbs.twimg.com/profile_images/719076434/____normal.png",
"profile_interstitial_type": "",
"screen_name": "kim_upsilon",
"statuses_count": 10081,
"translator_type": "regular",
"url": "https://t.co/vNMmyHHh15",
"verified": false,
"want_retweets": false,
"withheld_in_countries": []
}
}
}
},
"unmention_data": {},
"unified_card": {
"card_fetch_state": "NoCard"
},
"edit_control": {
"edit_tweet_ids": [
"1588614645866147840"
],
"editable_until_msecs": "1667592021000",
"is_edit_eligible": false,
"edits_remaining": "5"
},
"is_translatable": true,
"views": {
"state": "Enabled"
},
"source": "<a href=\"https://www.opentween.org/\" rel=\"nofollow\">OpenTween (dev)</a>",
"quoted_status_result": {
"result": {
"__typename": "Tweet",
"rest_id": "1583108196868116480",
"has_birdwatch_notes": false,
"core": {
"user_results": {
"result": {
"__typename": "User",
"id": "VXNlcjo0MDQ4MDY2NA==",
"rest_id": "40480664",
"affiliates_highlighted_label": {},
"has_graduated_access": false,
"is_blue_verified": false,
"profile_image_shape": "Circle",
"legacy": {
"can_dm": true,
"can_media_tag": true,
"created_at": "Sat May 16 15:20:01 +0000 2009",
"default_profile": false,
"default_profile_image": false,
"description": "",
"entities": {
"description": {
"urls": []
},
"url": {
"urls": [
{
"display_url": "m.upsilo.net/@upsilon",
"expanded_url": "https://m.upsilo.net/@upsilon",
"url": "https://t.co/vNMmyHHh15",
"indices": [
0,
23
]
}
]
}
},
"fast_followers_count": 0,
"favourites_count": 215369,
"followers_count": 1287,
"friends_count": 1,
"has_custom_timelines": false,
"is_translator": false,
"listed_count": 92,
"location": "Funabashi, Chiba, Japan",
"media_count": 876,
"name": "upsilon",
"needs_phone_verification": false,
"normal_followers_count": 1287,
"pinned_tweet_ids_str": [],
"possibly_sensitive": false,
"profile_banner_url": "https://pbs.twimg.com/profile_banners/40480664/1349188016",
"profile_image_url_https": "https://pbs.twimg.com/profile_images/719076434/____normal.png",
"profile_interstitial_type": "",
"screen_name": "kim_upsilon",
"statuses_count": 10081,
"translator_type": "regular",
"url": "https://t.co/vNMmyHHh15",
"verified": false,
"want_retweets": false,
"withheld_in_countries": []
}
}
}
},
"unmention_data": {},
"edit_control": {
"edit_tweet_ids": [
"1583108196868116480"
],
"editable_until_msecs": "1666279181000",
"is_edit_eligible": true,
"edits_remaining": "5"
},
"is_translatable": true,
"views": {
"state": "Enabled"
},
"source": "<a href=\"https://www.opentween.org/\" rel=\"nofollow\">OpenTween (dev)</a>",
"legacy": {
"bookmark_count": 0,
"bookmarked": false,
"created_at": "Thu Oct 20 14:49:41 +0000 2022",
"conversation_id_str": "1583108196868116480",
"display_text_range": [
0,
97
],
"entities": {
"user_mentions": [],
"urls": [],
"hashtags": [],
"symbols": []
},
"favorite_count": 2,
"favorited": false,
"full_text": "AppVeyorでビルドした時と自分の開発環境でビルドした時でなぜか sgen.exe の出力が異なって生成物のハッシュ値が一致しなくなる問題に悩み中。Reproducible Buildむずい",
"is_quote_status": false,
"lang": "ja",
"quote_count": 1,
"reply_count": 0,
"retweet_count": 0,
"retweeted": false,
"user_id_str": "40480664",
"id_str": "1583108196868116480"
}
}
},
"legacy": {
"bookmark_count": 0,
"bookmarked": false,
"created_at": "Fri Nov 04 19:30:21 +0000 2022",
"conversation_id_str": "1588614645866147840",
"display_text_range": [
0,
63
],
"entities": {
"user_mentions": [],
"urls": [
{
"display_url": "twitter.com/kim_upsilon/st…",
"expanded_url": "https://twitter.com/kim_upsilon/status/1583108196868116480",
"url": "https://t.co/mb89Ecojqd",
"indices": [
40,
63
]
}
],
"hashtags": [],
"symbols": []
},
"favorite_count": 2,
"favorited": false,
"full_text": "これ結局原因が分からないまま sgen.exe を使うのを止めることで解決した https://t.co/mb89Ecojqd",
"is_quote_status": true,
"lang": "ja",
"possibly_sensitive": false,
"possibly_sensitive_editable": true,
"quote_count": 0,
"quoted_status_id_str": "1583108196868116480",
"quoted_status_permalink": {
"url": "https://t.co/mb89Ecojqd",
"expanded": "https://twitter.com/kim_upsilon/status/1583108196868116480",
"display": "twitter.com/kim_upsilon/st…"
},
"reply_count": 1,
"retweet_count": 0,
"retweeted": false,
"user_id_str": "40480664",
"id_str": "1588614645866147840"
},
"quick_promote_eligibility": {
"eligibility": "IneligibleNotProfessional"
}
}
},
"tweetDisplayType": "SelfThread",
"hasModeratedReplies": false
}
Loading