-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial explainer for openable API. #1149
Open
lukewarlow
wants to merge
10
commits into
openui:main
Choose a base branch
from
lukewarlow:openable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
approved these changes
Feb 2, 2025
scottaohara
reviewed
Feb 3, 2025
Update Focus Management section Co-authored-by: Scott O'Hara <[email protected]>
scottaohara
reviewed
Feb 3, 2025
Update Accessibility/Semantics section Co-authored-by: Scott O'Hara <[email protected]>
scottaohara
reviewed
Feb 3, 2025
Update Alternatives Co-authored-by: Scott O'Hara <[email protected]>
scottaohara
reviewed
Feb 3, 2025
Update Why a content attribute? Co-authored-by: Scott O'Hara <[email protected]>
scottaohara
reviewed
Feb 3, 2025
i'll come back to flesh out more of this asap |
Update Example Use Cases Co-authored-by: Scott O'Hara <[email protected]>
lukewarlow
commented
Feb 4, 2025
Removed question as I've realised it's an easy question to answer.
Add missing defaultOpen to IDL, add question on whether this will conflict with potential popover default open?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft of an explainer for the proposed openable API see #700
The plan is to address the remaining chunks of this (such as the big "Why not
<details>
?" question) in follow-ups to make them easier to review. Some of these will need further discussion as a group too.