Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change meaning of ref and alt fields #142

Open
iskandr opened this issue Apr 18, 2016 · 0 comments
Open

Change meaning of ref and alt fields #142

iskandr opened this issue Apr 18, 2016 · 0 comments

Comments

@iskandr
Copy link
Contributor

iskandr commented Apr 18, 2016

Currently variant.ref and variant.alt don't contain any shared prefix or suffix. This confuses user since they expect whatever values passed in for these fields to be unchanged.

Breaking change: rename the current ref and alt fields to trimmed_ref and trimmed_alt and get rid of original_ref and original_alt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iskandr