Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformation pipeline to PrePostProcessing #28852

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

itikhono
Copy link
Contributor

@itikhono itikhono commented Feb 6, 2025

Details:

After switching from ModelOptimizer to OVC, the order of
applying PrePostProcessing and MOCTransformations has changed:

MO path : [fw model conversion -> PrePostProcessing -> MOC] -> nncf
OVC path: [fw model conversion -> MOC] -> PrePostProcessing -> nncf

 Since nncf is applied with a not fully optimized model, extra FQ ops might appear,
 which can affect both accuracy and performance.
e.g. Mul -> Conv fusion is not applied due to extra FQ
{C6E93F2C-2CE3-4596-8D7F-ED7BD8013603}
 PrePostProcessing is not part of OVC, so we have to insert additional
 Transformation calls inside PrePostProcessing.

Tickets:

@itikhono itikhono requested a review from a team as a code owner February 6, 2025 12:15
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Feb 6, 2025
@itikhono itikhono requested a review from a team as a code owner February 7, 2025 08:08
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Feb 7, 2025
@CuriousPanCake
Copy link
Contributor

I wonder if this makes the pipeline even more complicated. We have an issue of discrepancy between read/compile & convert, as far as I remember. Does it affect this in any way?

@itikhono
Copy link
Contributor Author

I wonder if this makes the pipeline even more complicated. We have an issue of discrepancy between read/compile & convert, as far as I remember. Does it affect this in any way?

we decided to call only the dedicated transformations instead of the MOC

@itikhono itikhono requested a review from a team as a code owner February 10, 2025 10:00
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Feb 10, 2025
@itikhono itikhono changed the title Add MOC transformations call to PrePostProcessing Add transformation pipeline to PrePostProcessing Feb 10, 2025
@itikhono itikhono requested a review from evkotov February 11, 2025 08:27
Copy link
Contributor

@CuriousPanCake CuriousPanCake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph) category: Python API OpenVINO Python bindings category: transformations OpenVINO Runtime library - Transformations do_not_merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants