-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flatpak: use a VM to build the package bundle #307
Open
claudioandre-br
wants to merge
1
commit into
main
Choose a base branch
from
flatpak
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+123
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudioandre-br
force-pushed
the
flatpak
branch
from
April 16, 2024 12:24
8d4aafa
to
ecda7e7
Compare
claudioandre-br
force-pushed
the
flatpak
branch
4 times, most recently
from
October 26, 2024 17:41
cfbdec2
to
58a296c
Compare
This comment has been minimized.
This comment has been minimized.
claudioandre-br
force-pushed
the
flatpak
branch
3 times, most recently
from
October 26, 2024 20:49
6ca51a1
to
27dba92
Compare
From
|
claudioandre-br
added a commit
that referenced
this pull request
Oct 31, 2024
In order to be able to test the package, we need to build the image outside of a Docker container. Both snap and flatpak cannot run correctly inside a Docker container. So add a VM that allows us to create and test the flatpak bundle. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
flatpak
branch
from
October 31, 2024 20:56
27dba92
to
2227e76
Compare
claudioandre-br
added a commit
that referenced
this pull request
Nov 1, 2024
In order to be able to test the package, we need to build the image outside of a Docker container. Both snap and flatpak cannot run correctly inside a Docker container. Our infrastructure at Gitlab is focused on Docker. So add a VM that allows us to create and test the flatpak bundle. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
flatpak
branch
from
November 1, 2024 14:26
2227e76
to
8b22f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved PR
claudioandre-br
added a commit
that referenced
this pull request
Nov 7, 2024
In order to be able to test the package, we need to build the image outside of a Docker container. Both snap and flatpak cannot run correctly inside a Docker container. Our infrastructure at Gitlab is focused on Docker. So add a VM that allows us to create and test the flatpak bundle. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
flatpak
branch
from
November 7, 2024 18:27
8b22f10
to
40f02e0
Compare
claudioandre-br
added
O: backlog
Backlog (stale ignores this label)
keep open
Do NOT close automatically.
and removed
O: backlog
Backlog (stale ignores this label)
labels
Nov 16, 2024
claudioandre-br
added a commit
that referenced
this pull request
Nov 17, 2024
In order to be able to test the package, we need to build the image outside of a Docker container. Both snap and flatpak cannot run correctly inside a Docker container. Our infrastructure at Gitlab is focused on Docker. So add a VM that allows us to create and test the flatpak bundle. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
flatpak
branch
from
November 17, 2024 21:06
40f02e0
to
43e339a
Compare
In order to be able to test the package, we need to build the image outside of a Docker container. Both snap and flatpak cannot run correctly inside a Docker container. Our infrastructure at Gitlab is focused on Docker. So add a VM that allows us to create and test the flatpak bundle. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
flatpak
branch
from
November 18, 2024 19:50
43e339a
to
b50736e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatpak and snap don't work inside a Docker container. Gitlab runners are based on Docker (in our case).
So, it's unclear how long we'll be able to build using Gitlab. This PR prepares us to face this future.
For our future, farewell Gitlab.
Describe your changes
In order to be able to test the package, we need to build the image outside of a Docker container. Both snap and flatpak cannot run correctly inside a Docker container.
So, stop using Gitlab to build the flatpak bundle.