Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md best practices #640

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update CONTRIBUTING.md best practices #640

merged 1 commit into from
Nov 22, 2024

Conversation

claudioandre-br
Copy link
Member

@claudioandre-br claudioandre-br commented Nov 21, 2024 •
edited
Loading

Describe your changes

Change notes on the intended formatting.

Issue ticket number and link

Add your text here.

Checklist before requesting a review

  • I checked that all workflows return a success.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I followed the Conventional Commit spec.

Maintainer tasks

  • Label as either: bug, ci, docker, documentation, enhancement.
  • Sign unsigned commits.

@claudioandre-br claudioandre-br added the documentation Improvements or additions to documentation label Nov 21, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2024
View reviewed changes
CONTRIBUTING.md Fixed Show fixed Hide fixed
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@claudioandre-br
docs(CONTRIBUTING.md): update best practices (#640)
294308d 
Change notes on the intended formatting.

Signed-off-by: Claudio André <[email protected]>
claudioandre-br
claudioandre-br commented Nov 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot approved these changes Nov 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved PR

@claudioandre-br
Copy link
Member Author

bot: MERGE skip

@github-actions GitHub Actions
Copy link 

🤖: status
- reviewDecision: APPROVED ✔
- mergeStateStatus: CLEAN ✔

@github-actions github-actions bot merged commit 294308d into openwall:main Nov 22, 2024
11 checks passed
@claudioandre-br claudioandre-br deleted the fix/docs branch November 22, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@claudioandre-br