fix: handle range proofs in presentation

[hallazzang]

Problem

If I specify multiple predicates on the same attribute when çreating a presentation request, like this:

requested_predicates: {
  age_gte: {
    name: "age",
    p_type: ">=",
    p_value: 20
  },
  age_lt: {
    name: "age",
    p_type: "<",
    p_value: 30
  }
}

The agent crashes due to this:

acapy/acapy_agent/protocols/present_proof/v2_0/formats/indy/handler.py

Lines 295 to 302 in 3d1682c

	if not (
	Predicate.get(proof_pred_spec["p_type"]) is req_pred
	and proof_pred_spec["value"] == req_value
	):
	raise V20PresFormatHandlerError(
	f"Presentation predicate on {req_name} "
	"mismatches proposal request"
	)

It happens when reft is age_lt(the second one) and ge_proof["predicate"] is { "attr_name": "age", "p_type": "GE", "value": 20 }(the first one).
It should just skip the first ge_proof but the current implementation raises an exception instead.

Solution

By checking both "attr_name" and "p_type" of proof_pred_spec, it is now possible to specify more than one predicate on a single attribute, enabling doing a range proof on an attribute.

[swcurran]

Thanks for the contribution. As per note on Discord, I'm not sure this is needed (can use restrictions instead), but I don't think it is harmful either.

Can you please fix the DCO checks that are failing (above). See DCO - Developer Certificate of Origin - https://github.com/apps/dco. To fix, see: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md and the details link beside the failed checks.

Perhaps also add a test for this?

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud