feat: OpenID4VP common OCA UI #1392
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
bryce-mcmath
requested changes
Jan 22, 2025
| @@ -738,7 +738,7 @@ EXTERNAL SOURCES: | |||
| SPEC CHECKSUMS: | |||
| anoncreds: 045f191123bb20d7dcdc2f7c19df57ae30c427f6 | |||
| aries-askar: 3a78d5cfc8faedbfc55a9ff35e2309fc4574a147 | |||
| boost: 7dcd2de282d72e344012f7d6564d024930a6a440 | |||
| boost: 57d2868c099736d80fcd648bf211b4431e51a558 | |||
There was a problem hiding this comment.
Not sure where this change came from or if it was meant to be included, but usually if the Podfile.lock gets changed the overall checksum should change as well. Probably best to just not include it since it doesn't seem related to the PR and no other dependencies have been changed
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress
Updating OpenID4VP to use common UI components and OCA for proof presentation
Screenshots, videos, or gifs
Replace this text with embedded media for UI changes if they are included in this PR. If there are none, simply enter N/A
Breaking change guide
Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A
Related Issues
Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓